[WFTC-136] Memory leak, remove XAResourceRecovery when reload #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcosgopen
changed the title
marcosgopen
force-pushed
the
WFTC-136
branch
from
08bce10
to
42240ab
Compare
mmusgrov
approved these changes
Sep 22, 2023
src/main/java/org/wildfly/transaction/client/provider/jboss/JBossLocalTransactionProvider.java
Show resolved
Hide resolved
|
|
||
| public void removeXAResourceRecovery(XAResourceRecoveryRegistry registry) { | ||
| registry.removeXAResourceRecovery(xaResourceRecovery); | ||
|
|
marcosgopen
force-pushed
the
WFTC-136
branch
from
42240ab
to
8733df8
Compare
chengfang
reviewed
Sep 22, 2023
| @@ -77,6 +78,7 @@ public abstract class JBossLocalTransactionProvider implements LocalTransactionP | |||
| private final ConcurrentSkipListSet<XidKey> timeoutSet = new ConcurrentSkipListSet<>(); | |||
| private final ConcurrentMap<SimpleXid, Entry> known = new ConcurrentHashMap<>(); | |||
| private final FileSystemXAResourceRegistry fileSystemXAResourceRegistry; | |||
| private XAResourceRecovery xaResourceRecovery; | |||
There was a problem hiding this comment.
this field can be final.
There was a problem hiding this comment.
Thanks @chengfang for your review! I addressed your comment.
chengfang
reviewed
Sep 22, 2023
src/main/java/org/wildfly/transaction/client/provider/jboss/JBossLocalTransactionProvider.java
Show resolved
Hide resolved
marcosgopen
force-pushed
the
WFTC-136
branch
from
8733df8
to
c30e7b3
Compare
chengfang
approved these changes
Sep 22, 2023
|
all 6 checks passed. |
|
@marcosgopen @mmusgrov thanks! |
chengfang
pushed a commit
to chengfang/wildfly-transaction-client
that referenced
this pull request
Sep 26, 2023
chengfang
added a commit
that referenced
this pull request
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/WFTC-136