WFTC-55: Fix for warn log messages to be identified with id #59
Conversation
|
Just a minor note. It might make sense to move these messages down to the bottom or add a comment after the last method in the interface so it's easy to determine where the id's have been left off. Any duplicates should be caught at build time, but it might just be helpful for the future. |
ochaloup
force-pushed
the
warn-to-be-with-id
branch
from
c56fec5
to
9fabe91
Compare
|
@jamezp this note sounds reasonable for me. I just hesitated to do so before as there was section for log messages and exceptions and I was unsure bout mixing them. But as defined now it's possibly better (I hope). |
ochaloup
force-pushed
the
warn-to-be-with-id
branch
from
9fabe91
to
4e0845c
Compare
|
@dmlloyd what do you think about this change and possibility the PR#58 could be merged |
|
This just needs a JIRA ID in the commit name and the PR name and I can merge it. |
|
I see, I need to create a new issue for this. Give me few minutes and I will do so. Thanks! |
ochaloup
force-pushed
the
warn-to-be-with-id
branch
from
4e0845c
to
21107d9
Compare
ochaloup
changed the title
|
@dmlloyd what do you think now? |
https://issues.jboss.org/browse/WFTC-55
Fixing the WARN messages would be marked with id as by standard that all log messages of INFO and higher should generally have message IDs.
/cc @fl4via @dmlloyd @wolfc