Convert Infinispan's transport channel capability's static requiremen…

…t to a resource capability reference.
wildfly · Apr 25, 2018 · 1e1a05d · 1e1a05d
1 parent 2bb0c1d
commit 1e1a05d
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 7 deletions.
diff --git a/.../common/src/main/java/org/jboss/as/clustering/controller/ResourceCapabilityReference.java b/.../common/src/main/java/org/jboss/as/clustering/controller/ResourceCapabilityReference.java
@@ -41,6 +41,16 @@ public class ResourceCapabilityReference extends AbstractCapabilityReference {
 
     private final Function<PathAddress, String[]> requirementNameResolver;
 
+    /**
+     * Creates a new reference between the specified capability and the specified requirement
+     * @param capability the capability referencing the specified requirement
+     * @param requirement the requirement of the specified capability
+     * @param requirementNameResolver function for resolving the dynamic elements of the requirement name
+     */
+    public ResourceCapabilityReference(Capability capability, Requirement requirement) {
+        this(capability, requirement, new SimpleCapabilityNameResolver());
+    }
+
     /**
      * Creates a new reference between the specified capability and the specified requirement
      * @param capability the capability referencing the specified requirement
@@ -77,7 +87,8 @@ public void removeCapabilityRequirements(OperationContext context, Resource reso
     }
 
     private String getRequirementName(OperationContext context) {
-        return RuntimeCapability.buildDynamicCapabilityName(this.getBaseRequirementName(), this.requirementNameResolver.apply(context.getCurrentAddress()));
+        String[] parts = this.requirementNameResolver.apply(context.getCurrentAddress());
+        return (parts.length > 0) ? RuntimeCapability.buildDynamicCapabilityName(this.getBaseRequirementName(), parts) : this.getBaseRequirementName();
     }
 
     @Override

diff --git a/...java/org/jboss/as/clustering/infinispan/subsystem/JGroupsTransportResourceDefinition.java b/...java/org/jboss/as/clustering/infinispan/subsystem/JGroupsTransportResourceDefinition.java
@@ -27,6 +27,7 @@
 
 import org.jboss.as.clustering.controller.CapabilityReference;
 import org.jboss.as.clustering.controller.DynamicCapabilityNameResolver;
+import org.jboss.as.clustering.controller.ResourceCapabilityReference;
 import org.jboss.as.clustering.controller.ResourceDescriptor;
 import org.jboss.as.clustering.controller.SimpleAliasEntry;
 import org.jboss.as.clustering.controller.UnaryRequirementCapability;
@@ -91,12 +92,7 @@ public Class<?> getType() {
     }
 
     enum Capability implements org.jboss.as.clustering.controller.Capability, UnaryOperator<RuntimeCapability.Builder<Void>> {
-        TRANSPORT_CHANNEL(Requirement.CHANNEL) {
-            @Override
-            public RuntimeCapability.Builder<Void> apply(RuntimeCapability.Builder<Void> builder) {
-                return super.apply(builder).addRequirements(JGroupsDefaultRequirement.CHANNEL_FACTORY.getName());
-            }
-        },
+        TRANSPORT_CHANNEL(Requirement.CHANNEL),
         ;
         private final RuntimeCapability<Void> definition;
 
@@ -295,6 +291,7 @@ public ResourceDescriptor apply(ResourceDescriptor descriptor) {
                     .addAttributes(ExecutorAttribute.class)
                     .addAttributes(DeprecatedAttribute.class)
                     .addCapabilities(Capability.class)
+                    .addResourceCapabilityReference(new ResourceCapabilityReference(Capability.TRANSPORT_CHANNEL, JGroupsDefaultRequirement.CHANNEL_FACTORY))
                     ;
         }
     }