Merge pull request #17051 from bstansberry/WFLY-18296_29x

[WFLY-18296] Remove the org.jboss.jts dependency on jdk.console
wildfly · Aug 23, 2023 · b6febff · b6febff
2 parents 7305e04 + c40fee8
commit b6febff
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/...n-shared/src/main/resources/modules/system/layers/base/org/glassfish/jaxb/main/module.xml b/...n-shared/src/main/resources/modules/system/layers/base/org/glassfish/jaxb/main/module.xml
@@ -42,7 +42,7 @@
         <module name="java.xml"/>
         <module name="jakarta.activation.api"/>
         <module name="jakarta.xml.bind.api"/>
-        <module name="jdk.compiler"/>
+        <module name="jdk.compiler" optional="true"/>
     </dependencies>
 
 </module>
diff --git a/...alleon-shared/src/main/resources/modules/system/layers/base/org/jboss/jts/main/module.xml b/...alleon-shared/src/main/resources/modules/system/layers/base/org/jboss/jts/main/module.xml
@@ -41,7 +41,20 @@
         <module name="java.transaction.xa"/>
         <module name="java.xml"/>
         <module name="jakarta.transaction.api"/>
+		<!--
+			The jdk.console module is a compile dependency of narayana-jts-idlj
+			but is not a runtime one within WildFly. It's listed here with
+			this comment to prevent it being re-added as a dependency
+			without discussion.
+			
+			Narayana has a 'TxPerfPlugin' JConsolePlugin implementation but 
+			WildFly does not support running JConsole as a modular application.
+			
+			WildFly should not have dependencies on JDK modules that are not 
+			associated with the traditional 'JRE' concept.
+			 
         <module name="jdk.jconsole"/>
+        -->
         <module name="org.omg.api" />
         <module name="org.jboss.logging"/>
         <module name="org.jboss.jts.integration"/>