Skip to content

Commit

Permalink
Drop unnecessary Supplier wrapper when configuring web routing.
Browse files Browse the repository at this point in the history
  • Loading branch information
pferraro committed Oct 31, 2017
1 parent 1ea5128 commit df79d29
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 8 deletions.
Expand Up @@ -25,7 +25,6 @@
import java.util.LinkedList;
import java.util.List;
import java.util.ServiceLoader;
import java.util.function.Supplier;

import org.infinispan.configuration.cache.CacheMode;
import org.jboss.as.clustering.controller.CapabilityServiceBuilder;
Expand Down Expand Up @@ -55,12 +54,12 @@ public CapabilityServiceBuilder<RouteLocator> getRouteLocatorBuilder(String serv
}

@Override
public Collection<CapabilityServiceBuilder<?>> getRouteLocatorConfigurationBuilders(String serverName, Supplier<ValueDependency<String>> routeDependencyProvider) {
public Collection<CapabilityServiceBuilder<?>> getRouteLocatorConfigurationBuilders(String serverName, ValueDependency<String> routeDependency) {
String containerName = InfinispanSessionManagerFactoryBuilder.DEFAULT_CACHE_CONTAINER;

List<CapabilityServiceBuilder<?>> builders = new LinkedList<>();

builders.add(new RouteRegistryEntryProviderBuilder(serverName, routeDependencyProvider.get()));
builders.add(new RouteRegistryEntryProviderBuilder(serverName, routeDependency));
builders.add(new TemplateConfigurationBuilder(ServiceName.parse(InfinispanCacheRequirement.CONFIGURATION.resolve(containerName, serverName)), containerName, serverName, null, builder -> {
CacheMode mode = builder.clustering().cacheMode();
builder.clustering().cacheMode(mode.isClustered() ? CacheMode.REPL_SYNC : CacheMode.LOCAL);
Expand Down
Expand Up @@ -22,7 +22,6 @@
package org.wildfly.clustering.web.session;

import java.util.Collection;
import java.util.function.Supplier;

import org.jboss.as.clustering.controller.CapabilityServiceBuilder;
import org.wildfly.clustering.service.ValueDependency;
Expand All @@ -44,5 +43,5 @@ public interface RouteLocatorBuilderProvider {
* @param route the injected route source
* @return a service builder
*/
Collection<CapabilityServiceBuilder<?>> getRouteLocatorConfigurationBuilders(String serverName, Supplier<ValueDependency<String>> routeDependencyProvider);
Collection<CapabilityServiceBuilder<?>> getRouteLocatorConfigurationBuilders(String serverName, ValueDependency<String> routeDependencyProvider);
}
Expand Up @@ -26,7 +26,6 @@
import java.util.LinkedList;
import java.util.Optional;
import java.util.ServiceLoader;
import java.util.function.Supplier;
import java.util.stream.StreamSupport;

import org.jboss.as.clustering.controller.CapabilityServiceBuilder;
Expand Down Expand Up @@ -57,8 +56,8 @@ public Collection<CapabilityServiceBuilder<?>> getServerBuilders(String serverNa
Collection<CapabilityServiceBuilder<?>> builders = new LinkedList<>();
CapabilityServiceBuilder<String> routeBuilder = new RouteBuilder(serverName);
builders.add(routeBuilder);
Supplier<ValueDependency<String>> routeDependencyProvider = () -> new InjectedValueDependency<>(routeBuilder, String.class);
PROVIDER.ifPresent(provider -> builders.addAll(provider.getRouteLocatorConfigurationBuilders(serverName, routeDependencyProvider)));
ValueDependency<String> routeDependency = new InjectedValueDependency<>(routeBuilder, String.class);
PROVIDER.ifPresent(provider -> builders.addAll(provider.getRouteLocatorConfigurationBuilders(serverName, routeDependency)));
return builders;
}
}

0 comments on commit df79d29

Please sign in to comment.