Skip to content

Commit

Permalink
Revert "WFLY-9004 Artemis leaks JGroups channels on reload"
Browse files Browse the repository at this point in the history
This reverts commit 13bc1c1.
  • Loading branch information
jmesnil committed Jul 21, 2017
1 parent 8894869 commit fe7be83
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 96 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@

import org.apache.activemq.artemis.api.core.BroadcastEndpointFactory;
import org.apache.activemq.artemis.api.core.BroadcastGroupConfiguration;
import org.apache.activemq.artemis.api.core.ChannelBroadcastEndpointFactory;
import org.apache.activemq.artemis.api.core.UDPBroadcastEndpointFactory;
import org.apache.activemq.artemis.core.config.Configuration;
import org.jboss.as.controller.AbstractAddStepHandler;
Expand Down Expand Up @@ -180,7 +181,7 @@ static BroadcastGroupConfiguration createBroadcastGroupConfiguration(final Strin
final long broadcastPeriod = config.getBroadcastPeriod();
final List<String> connectorRefs = config.getConnectorInfos();

final BroadcastEndpointFactory endpointFactory = new ClosingChannelBroadcastEndpointFactory(channel, channelName);
final BroadcastEndpointFactory endpointFactory = new ChannelBroadcastEndpointFactory(channel, channelName);

return new BroadcastGroupConfiguration()
.setName(name)
Expand Down

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
import java.util.Map;

import org.apache.activemq.artemis.api.core.BroadcastEndpointFactory;
import org.apache.activemq.artemis.api.core.ChannelBroadcastEndpointFactory;
import org.apache.activemq.artemis.api.core.DiscoveryGroupConfiguration;
import org.apache.activemq.artemis.api.core.UDPBroadcastEndpointFactory;
import org.apache.activemq.artemis.core.config.Configuration;
Expand Down Expand Up @@ -152,7 +153,7 @@ static DiscoveryGroupConfiguration createDiscoveryGroupConfiguration(final Strin
final long refreshTimeout = config.getRefreshTimeout();
final long initialWaitTimeout = config.getDiscoveryInitialWaitTimeout();

final BroadcastEndpointFactory endpointFactory = new ClosingChannelBroadcastEndpointFactory(channel, channelName);
final BroadcastEndpointFactory endpointFactory = new ChannelBroadcastEndpointFactory(channel, channelName);

return new DiscoveryGroupConfiguration()
.setName(name)
Expand Down

0 comments on commit fe7be83

Please sign in to comment.