Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AS-1381 Make RA main config properties sub resources. Still needed ones r #455

Closed
wants to merge 2 commits into from
Closed

AS-1381 Make RA main config properties sub resources. Still needed ones r #455

wants to merge 2 commits into from

Conversation

maeste
Copy link
Contributor

@maeste maeste commented Oct 17, 2011

AS-1381 Make RA main config properties sub resources. Still needed ones relative to connection-definition and admin-object
AS7-1881 Some property in resource-adapters are duplicated in wrong positions
AS7-1379 Provide the ability to update RA attributes

@heiko-braun
Copy link
Contributor

When testing the patch I get this upon creating of an RA through the console:

14:24:55,591 ERROR [org.jboss.as.controller](HttpManagementService-threads - 1) Failed to persist configuration change: org.jboss.as.controller.persistence.ConfigurationPersistenceException: Failed to marshal configuration
at org.jboss.as.controller.persistence.FilePersistenceResource.(FilePersistenceResource.java:62) [jboss-as-controller-7.1.0.Alpha2-SNAPSHOT.jar:7.1.0.Alpha2-SNAPSHOT]
at org.jboss.as.controller.persistence.ConfigurationFilePersistenceResource.(ConfigurationFilePersistenceResource.java:39) [jboss-as-controller-7.1.0.Alpha2-SNAPSHOT.jar:7.1.0.Alpha2-SNAPSHOT]
at org.jboss.as.controller.persistence.BackupXmlConfigurationPersister.store(BackupXmlConfigurationPersister.java:80) [jboss-as-controller-7.1.0.Alpha2-SNAPSHOT.jar:7.1.0.Alpha2-SNAPSHOT]
at org.jboss.as.controller.ModelControllerImpl.writeModel(ModelControllerImpl.java:282) [jboss-as-controller-7.1.0.Alpha2-SNAPSHOT.jar:7.1.0.Alpha2-SNAPSHOT]
at org.jboss.as.controller.OperationContextImpl.doCompleteStep(OperationContextImpl.java:312) [jboss-as-controller-7.1.0.Alpha2-SNAPSHOT.jar:7.1.0.Alpha2-SNAPSHOT]
at org.jboss.as.controller.OperationContextImpl.completeStep(OperationContextImpl.java:219) [jboss-as-controller-7.1.0.Alpha2-SNAPSHOT.jar:7.1.0.Alpha2-SNAPSHOT]
at org.jboss.as.controller.OperationContextImpl.executeStep(OperationContextImpl.java:440) [jboss-as-controller-7.1.0.Alpha2-SNAPSHOT.jar:7.1.0.Alpha2-SNAPSHOT]
at org.jboss.as.controller.OperationContextImpl.doCompleteStep(OperationContextImpl.java:285) [jboss-as-controller-7.1.0.Alpha2-SNAPSHOT.jar:7.1.0.Alpha2-SNAPSHOT]
at org.jboss.as.controller.OperationContextImpl.completeStep(OperationContextImpl.java:219) [jboss-as-controller-7.1.0.Alpha2-SNAPSHOT.jar:7.1.0.Alpha2-SNAPSHOT]
at org.jboss.as.connector.subsystems.resourceadapters.RaAdd$1.execute(RaAdd.java:88) [jboss-as-connector-7.1.0.Alpha2-SNAPSHOT.jar:7.1.0.Alpha2-SNAPSHOT]
at org.jboss.as.controller.OperationContextImpl.executeStep(OperationContextImpl.java:386) [jboss-as-controller-7.1.0.Alpha2-SNAPSHOT.jar:7.1.0.Alpha2-SNAPSHOT]
at org.jboss.as.controller.OperationContextImpl.doCompleteStep(OperationContextImpl.java:285) [jboss-as-controller-7.1.0.Alpha2-SNAPSHOT.jar:7.1.0.Alpha2-SNAPSHOT]
at org.jboss.as.controller.OperationContextImpl.completeStep(OperationContextImpl.java:219) [jboss-as-controller-7.1.0.Alpha2-SNAPSHOT.jar:7.1.0.Alpha2-SNAPSHOT]
at org.jboss.as.connector.subsystems.resourceadapters.RaAdd.execute(RaAdd.java:96) [jboss-as-connector-7.1.0.Alpha2-SNAPSHOT.jar:7.1.0.Alpha2-SNAPSHOT]
at org.jboss.as.controller.OperationContextImpl.executeStep(OperationContextImpl.java:386) [jboss-as-controller-7.1.0.Alpha2-SNAPSHOT.jar:7.1.0.Alpha2-SNAPSHOT]
at org.jboss.as.controller.OperationContextImpl.doCompleteStep(OperationContextImpl.java:285) [jboss-as-controller-7.1.0.Alpha2-SNAPSHOT.jar:7.1.0.Alpha2-SNAPSHOT]
at org.jboss.as.controller.OperationContextImpl.completeStep(OperationContextImpl.java:219) [jboss-as-controller-7.1.0.Alpha2-SNAPSHOT.jar:7.1.0.Alpha2-SNAPSHOT]
at org.jboss.as.controller.ModelControllerImpl$DefaultPrepareStepHandler.execute(ModelControllerImpl.java:371) [jboss-as-controller-7.1.0.Alpha2-SNAPSHOT.jar:7.1.0.Alpha2-SNAPSHOT]
at org.jboss.as.controller.OperationContextImpl.executeStep(OperationContextImpl.java:386) [jboss-as-controller-7.1.0.Alpha2-SNAPSHOT.jar:7.1.0.Alpha2-SNAPSHOT]
at org.jboss.as.controller.OperationContextImpl.doCompleteStep(OperationContextImpl.java:285) [jboss-as-controller-7.1.0.Alpha2-SNAPSHOT.jar:7.1.0.Alpha2-SNAPSHOT]
at org.jboss.as.controller.OperationContextImpl.completeStep(OperationContextImpl.java:219) [jboss-as-controller-7.1.0.Alpha2-SNAPSHOT.jar:7.1.0.Alpha2-SNAPSHOT]
at org.jboss.as.controller.ModelControllerImpl.execute(ModelControllerImpl.java:108) [jboss-as-controller-7.1.0.Alpha2-SNAPSHOT.jar:7.1.0.Alpha2-SNAPSHOT]
at org.jboss.as.controller.ModelControllerImpl$1.execute(ModelControllerImpl.java:230) [jboss-as-controller-7.1.0.Alpha2-SNAPSHOT.jar:7.1.0.Alpha2-SNAPSHOT]
at org.jboss.as.controller.ModelControllerImpl$1.execute(ModelControllerImpl.java:220) [jboss-as-controller-7.1.0.Alpha2-SNAPSHOT.jar:7.1.0.Alpha2-SNAPSHOT]
at org.jboss.as.domain.http.server.DomainApiHandler.processRequest(DomainApiHandler.java:199)
at org.jboss.as.domain.http.server.DomainApiHandler.handle(DomainApiHandler.java:127)
at org.jboss.com.sun.net.httpserver.Filter$Chain.doFilter(Filter.java:78)
at org.jboss.sun.net.httpserver.AuthFilter.doFilter(AuthFilter.java:80)
at org.jboss.com.sun.net.httpserver.Filter$Chain.doFilter(Filter.java:81)
at org.jboss.sun.net.httpserver.ServerImpl$Exchange$LinkHandler.handle(ServerImpl.java:689)
at org.jboss.com.sun.net.httpserver.Filter$Chain.doFilter(Filter.java:78)
at org.jboss.sun.net.httpserver.ServerImpl$Exchange.run(ServerImpl.java:661)
at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) [:1.6.0_26]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) [:1.6.0_26]
at java.lang.Thread.run(Thread.java:680) [:1.6.0_26]
at org.jboss.threads.JBossThread.run(JBossThread.java:122) [jboss-threads-2.0.0.GA.jar:2.0.0.GA]
Caused by: org.jboss.as.controller.persistence.ConfigurationPersistenceException: Failed to write configuration
at org.jboss.as.controller.persistence.AbstractConfigurationPersister.marshallAsXml(AbstractConfigurationPersister.java:109) [jboss-as-controller-7.1.0.Alpha2-SNAPSHOT.jar:7.1.0.Alpha2-SNAPSHOT]
at org.jboss.as.controller.persistence.FilePersistenceResource.(FilePersistenceResource.java:55) [jboss-as-controller-7.1.0.Alpha2-SNAPSHOT.jar:7.1.0.Alpha2-SNAPSHOT]
... 35 more
Caused by: java.lang.IllegalArgumentException
at org.jboss.dmr.ModelValue.getChild(ModelValue.java:108) [jboss-dmr-1.0.0.Final.jar:1.0.0.Final]
at org.jboss.dmr.ModelNode.get(ModelNode.java:689) [jboss-dmr-1.0.0.Final.jar:1.0.0.Final]
at org.jboss.as.connector.subsystems.resourceadapters.ResourceAdaptersExtension$ResourceAdapterSubsystemParser.writeNewConfigProperties(ResourceAdaptersExtension.java:289) [jboss-as-connector-7.1.0.Alpha2-SNAPSHOT.jar:7.1.0.Alpha2-SNAPSHOT]
at org.jboss.as.connector.subsystems.resourceadapters.ResourceAdaptersExtension$ResourceAdapterSubsystemParser.writeRaElement(ResourceAdaptersExtension.java:255) [jboss-as-connector-7.1.0.Alpha2-SNAPSHOT.jar:7.1.0.Alpha2-SNAPSHOT]
at org.jboss.as.connector.subsystems.resourceadapters.ResourceAdaptersExtension$ResourceAdapterSubsystemParser.writeContent(ResourceAdaptersExtension.java:234) [jboss-as-connector-7.1.0.Alpha2-SNAPSHOT.jar:7.1.0.Alpha2-SNAPSHOT]
at org.jboss.as.connector.subsystems.resourceadapters.ResourceAdaptersExtension$ResourceAdapterSubsystemParser.writeContent(ResourceAdaptersExtension.java:216) [jboss-as-connector-7.1.0.Alpha2-SNAPSHOT.jar:7.1.0.Alpha2-SNAPSHOT]
at org.jboss.as.controller.parsing.StandaloneXml.writeServerProfile(StandaloneXml.java:571) [jboss-as-controller-7.1.0.Alpha2-SNAPSHOT.jar:7.1.0.Alpha2-SNAPSHOT]
at org.jboss.as.controller.parsing.StandaloneXml.writeContent(StandaloneXml.java:499) [jboss-as-controller-7.1.0.Alpha2-SNAPSHOT.jar:7.1.0.Alpha2-SNAPSHOT]
at org.jboss.as.controller.parsing.StandaloneXml.writeContent(StandaloneXml.java:82) [jboss-as-controller-7.1.0.Alpha2-SNAPSHOT.jar:7.1.0.Alpha2-SNAPSHOT]
at org.jboss.staxmapper.XMLMapperImpl.doDeparse(XMLMapperImpl.java:78) [staxmapper-1.0.0.Final.jar:1.0.0.Final]
at org.jboss.staxmapper.XMLMapperImpl.deparseDocument(XMLMapperImpl.java:73) [staxmapper-1.0.0.Final.jar:1.0.0.Final]
at org.jboss.as.controller.persistence.AbstractConfigurationPersister.marshallAsXml(AbstractConfigurationPersister.java:103) [jboss-as-controller-7.1.0.Alpha2-SNAPSHOT.jar:7.1.0.Alpha2-SNAPSHOT]
... 36 more

14:24:55,599 INFO [org.jboss.as.controller](MSC service thread 1-3) Service status report
New missing/unsatisfied dependencies:
service jboss.resourceadapters (missing)

@heiko-braun
Copy link
Contributor

my bad. i did use a wrong operation syntax

@maeste
AS-1381 Make RA main config properties sub resources.Also for ones re…
0ed6c61 
…lative to connection-definition and admin-object

AS7-1881 Some property in resource-adapters are duplicated in wrong positions
AS7-1379 Provide the ability to update RA attributes
@maeste
fixing resource-adapter decription
abe5b58
bstansberry
bstansberry reviewed Oct 20, 2011
View reviewed changes
connector/src/main/java/org/jboss/as/connector/pool/Constants.java
@@ -58,11 +58,11 @@ public class Constants {
private static final String FLUSH_STRATEGY_NAME = "flush-strategy";


public static final SimpleAttributeDefinition BLOCKING_TIMEOUT_WAIT_MILLIS = new SimpleAttributeDefinition(BLOCKING_TIMEOUT_WAIT_MILLIS_NAME, TimeOut.Tag.BLOCKING_TIMEOUT_MILLIS.getLocalName(), new ModelNode(), ModelType.LONG, false, true, MeasurementUnit.MILLISECONDS);
public static final SimpleAttributeDefinition BLOCKING_TIMEOUT_WAIT_MILLIS = new SimpleAttributeDefinition(BLOCKING_TIMEOUT_WAIT_MILLIS_NAME, TimeOut.Tag.BLOCKING_TIMEOUT_MILLIS.getLocalName(), new ModelNode(), ModelType.LONG, true , true, MeasurementUnit.MILLISECONDS);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a SimpleAttributeDefinitionBuilder class that can help with these nasty constructors.

@bstansberry
Copy link
Contributor

Merged. http://github.com/jbossas/jboss-as/compare/c9ecaa1...6c58c5f

clebertsuconic pushed a commit to clebertsuconic/wildfly that referenced this pull request Apr 14, 2016
@n1hility
Merge pull request wildfly#455 from dosoudil/JBEAP-4088
8a353c9 
[JBEAP-4088] Prod rebuild of HAL 2.8.24.Final
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maeste @heiko-braun @bstansberry