New XTS integration tests #4928

ochaloup · 2013-08-15T18:41:03Z

Changed tests based on narayana XTS tests. More details at https://issues.jboss.org/browse/JBQA-7126.

wildfly-ci · 2013-08-15T18:42:18Z

Build 455 is now running using a merge of 3b9539536bf0ff460f7344d9b495377f37fb9b04

wildfly-ci · 2013-08-15T20:12:49Z

Build 455 outcome was FAILURE using a merge of 3b9539536bf0ff460f7344d9b495377f37fb9b04
Summary: Tests failed: 2 (2 new), passed: 4405, ignored: 83 Build time: 1:30:30

Failed tests

org.jboss.as.test.clustering.cluster.ejb3.stateless.RemoteStatelessFailoverTestCase(SYNC-tcp).testLoadBalance: java.lang.AssertionError: expected:<2> but was:<1>
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.failNotEquals(Assert.java:743)

org.jboss.as.test.clustering.cluster.ejb3.stateless.RemoteStatelessFailoverTestCase(SYNC-tcp).testFailoverOnStop: java.util.ConcurrentModificationException
    at java.util.HashMap$HashIterator.nextEntry(HashMap.java:894)
    at java.util.HashMap$KeyIterator.next(HashMap.java:928)

paulrobinson · 2013-08-16T17:22:05Z

Looks like an intermittent failure to me:

retest this please

wildfly-ci · 2013-08-16T17:22:18Z

Build 465 is now running using a merge of 3b9539536bf0ff460f7344d9b495377f37fb9b04

paulrobinson · 2013-08-16T17:46:41Z

testsuite/integration/xts/src/test/java/org/jboss/as/test/xts/wsat/client/ATTestCase.java

+                .addPackage(EventLog.class.getPackage())
+                .addPackage(BaseFunctionalTest.class.getPackage())
+
+                .addAsResource("context-handlers.xml") // is this needed?


Yes, it is is still needed to setup the server-side handler chain. We are working on inferring this and adding automatically in the subsystem.

paulrobinson · 2013-08-16T17:50:47Z

You may want to squash the commits as they all relate to the same issue.

paulrobinson · 2013-08-16T17:51:27Z

I think you need to remove MockSet and all it's usages. I don't think it has any active role in the tests? See my previous comment about how I think it got included.

paulrobinson · 2013-08-16T17:52:37Z

testsuite/integration/xts/src/test/java/org/jboss/as/test/xts/wsat/client/ATClient.java

+    private static final Logger log = Logger.getLogger(ATClient.class);
+
+    private static final String NODE0_ADDR = System.getProperty("node0", "localhost");
+    //TODO: parameterize this - /socket-binding-group=standard-sockets/socket-binding=http:read-attribute(name=port)


Do you need to do this? I agree you would need this for regular code, but for tests?

@bstansberry Does the todo need addressing for tests?

No, hard coding 8080 is fine.

The handling of NODE0_ADDR needs fixing though. The string needs to be passed through a routine like org.jboss.as.network.NetworkUtils.formatPossibleIpv6Address(...) before it can be used in the URL at L53 below. We commonly configure CI runs to bind node0 to an IPv6 address.

wildfly-ci · 2013-08-16T18:58:29Z

Build 465 outcome was SUCCESS using a merge of 3b9539536bf0ff460f7344d9b495377f37fb9b04
Summary: Tests passed: 4407, ignored: 83 Build time: 1:36:11

wildfly-ci · 2013-08-19T10:06:58Z

Build 209 is now running using a merge of 3b9539536bf0ff460f7344d9b495377f37fb9b04

wildfly-ci · 2013-08-19T11:17:07Z

Build 209 outcome was SUCCESS using a merge of 3b9539536bf0ff460f7344d9b495377f37fb9b04
Summary: Tests passed: 4412, ignored: 84 Build time: 1:10:8

bstansberry · 2013-08-20T16:26:36Z

@paulrobinson -- given the number of comments you've had on this, I'm not going to try and figure out when they've been satisfactorily addressed. So when this PR is ok with you, please be sure and add a comment explicitly approving it.

Thanks!

paulrobinson · 2013-08-20T20:38:50Z

No problem @bstansberry,I'll keep an eye on it. I am on Holiday until the 26th August, so may not reply immediately.

ctomc · 2013-08-20T22:42:16Z

testsuite/integration/xts/src/test/java/org/jboss/as/test/xts/wsat/service/ATSuperService.java

+        try {
+            userTransaction = UserTransactionFactory.userTransaction();
+            String transactionId = userTransaction.transactionIdentifier();
+            System.out.println("RestaurantServiceAT transaction id =" + transactionId);


system out an log? in same test?

ochaloup · 2013-08-21T11:29:35Z

Hi,

thank you for the comments.

@paulrobinson: I've removed MockSet object. Initially I thought that it is fine to "simulate" some business logic. And I've squashed the commits as you proposed.
@bstansberry: Thanks. I used the proposed NetworkUtils.formatPossibleIpv6Address method.
@ctomc: Sorry, my mistake. Changed to be looged by logger

jaikiran · 2013-08-22T08:32:34Z

retest this please

wildfly-ci · 2013-08-22T08:36:13Z

Build 258 is now running using a merge of dc021c1414bf84037a9de8069641f4eb4f206539

wildfly-ci · 2013-08-22T09:48:59Z

Build 258 outcome was SUCCESS using a merge of dc021c1414bf84037a9de8069641f4eb4f206539
Summary: Tests passed: 4426, ignored: 84 Build time: 1:12:46

paulrobinson · 2013-08-26T13:07:56Z

@bstansberry All my comments have been satisfactorily addressed.

bstansberry · 2013-08-26T14:18:54Z

@paulrobinson thanks

So, whoever next merges a set of pulls (maybe me!!), this is good to go.

jaikiran · 2013-08-27T06:48:50Z

...org/jboss/as/test/xts/wsba/coordinatorcompletion/client/BACoordinatorCompletionTestCase.java

+                .addAsWebInfResource(EmptyAsset.INSTANCE, ArchivePaths.create("beans.xml"))
+                .addAsManifestResource(new StringAsset("Dependencies: org.jboss.xts,org.jboss.jts\n"), "MANIFEST.MF");
+
+        File testPackage = new File("/tmp", ARCHIVE_NAME + ".war");


This fails on windows for obvious reasons. Is this used anywhere in the test? If not, better just remove this.

Here's the exception stacktrace for reference:

Caused by: org.jboss.shrinkwrap.api.exporter.ArchiveExportException: File could not be created: \tmp\wsba-coordinatorcompletition-test.war at org.jboss.shrinkwrap.impl.base.exporter.AbstractStreamExporterImpl.getOutputStreamToFile(AbstractStreamExporterImpl.java:95) at org.jboss.shrinkwrap.impl.base.exporter.AbstractStreamExporterImpl.exportTo(AbstractStreamExporterImpl.java:144) at org.jboss.as.test.xts.wsba.coordinatorcompletion.client.BACoordinatorCompletionTestCase.createTestArchive(BACoordinatorCompletionTestCase.java:84) ... 59 more

no, you are absolutely right. It has nothing to do in the code. That was my inattention which left the code at the place. I've checked it and I hope that there won't be more stuff like that. I removed that from the pull request. Sorry.

wildfly-ci · 2013-08-27T08:41:21Z

Build 310 is now running using a merge of 76207f7

wildfly-ci · 2013-08-27T10:41:30Z

Build 310 outcome was FAILURE using a merge of 76207f7
Summary: Execution timeout (new); tests failed: 7 (7 new), passed: 4241, ignored: 81; org.wildfly:wildfly-ts-integ-manualmode Build time: 2:0:9

Failed tests

org.jboss.as.test.smoke.webservices.WSTestCase.testManagementDescription: java.util.concurrent.TimeoutException
    at java.util.concurrent.FutureTask$Sync.innerGet(FutureTask.java:258)
    at java.util.concurrent.FutureTask.get(FutureTask.java:119)

org.jboss.as.test.integration.ejb.timerservice.schedule.SimpleScheduleSecondTestCase.testScheduleMethodTimeout: java.lang.AssertionError
    at org.junit.Assert.fail(Assert.java:86)
    at org.junit.Assert.assertTrue(Assert.java:41)

org.jboss.as.test.manualmode.messaging.HornetQBackupActivationTestCase.testActiveBackupReload: java.lang.IllegalArgumentException
    at org.jboss.dmr.ModelValue.asBoolean(ModelValue.java:66)
    at org.jboss.dmr.ModelNode.asBoolean(ModelNode.java:262)

org.jboss.as.test.manualmode.messaging.HornetQBackupActivationTestCase.testPassiveBackupReload: java.lang.IllegalArgumentException
    at org.jboss.dmr.ModelValue.asBoolean(ModelValue.java:66)
    at org.jboss.dmr.ModelNode.asBoolean(ModelNode.java:262)

org.jboss.as.test.manualmode.messaging.HornetQBackupActivationTestCase.testBackupActivation: java.lang.IllegalArgumentException
    at org.jboss.dmr.ModelValue.asBoolean(ModelValue.java:66)
    at org.jboss.dmr.ModelNode.asBoolean(ModelNode.java:262)

org.jboss.as.test.manualmode.messaging.HornetQBackupActivationTestCase.testLiveReload: java.lang.IllegalArgumentException
    at org.jboss.dmr.ModelValue.asBoolean(ModelValue.java:66)
    at org.jboss.dmr.ModelNode.asBoolean(ModelNode.java:262)

org.jboss.as.test.manualmode.messaging.HornetQBackupActivationTestCase.testBackupFailoverAfterFailback: java.lang.IllegalArgumentException
    at org.jboss.dmr.ModelValue.asBoolean(ModelValue.java:66)
    at org.jboss.dmr.ModelNode.asBoolean(ModelNode.java:262)

ochaloup · 2013-08-27T10:42:59Z

the fails seems to me not to be connected with the pull request

retest this please

wildfly-ci · 2013-08-27T10:46:18Z

Build 312 is now running using a merge of 76207f7

wildfly-ci · 2013-08-27T12:26:51Z

Build 312 outcome was FAILURE using a merge of 76207f7
Summary: Tests failed: 1, passed: 4328, ignored: 83 Build time: 1:40:34

Failed tests

org.jboss.as.test.smoke.webservices.WSTestCase.testManagementDescription: java.util.concurrent.TimeoutException
    at java.util.concurrent.FutureTask$Sync.innerGet(FutureTask.java:258)
    at java.util.concurrent.FutureTask.get(FutureTask.java:119)

n1hility · 2013-08-27T21:21:41Z

merging

n1hility · 2013-08-28T00:50:26Z

merged

wildfly-ci · 2013-08-29T21:29:27Z

Build 364 is now running using a merge of 76207f7

wildfly-ci · 2013-08-29T22:51:26Z

Build 364 outcome was FAILURE using a merge of 76207f7
Summary: Tests failed: 1 (1 new), passed: 4525, ignored: 86 Build time: 1:22:0

Failed tests

org.jboss.as.test.integration.domain.suites.DomainTestSuite: org.jboss.as.test.integration.domain.suites.DeploymentManagementTestCase.testFullReplaceViaHash: java.lang.AssertionError: /opt/buildAgent/work/340a2b56aab3b1db/testsuite/domain/target/domains/DomainTestSuite/master/data/content/21
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.assertTrue(Assert.java:41)

paulrobinson reviewed Aug 16, 2013
View reviewed changes

ctomc reviewed Aug 20, 2013
View reviewed changes

jaikiran reviewed Aug 27, 2013
View reviewed changes

[JBQA-7126] New XTS integration tests (old ones deleted)

76207f7

n1hility closed this Aug 28, 2013

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New XTS integration tests #4928

New XTS integration tests #4928

ochaloup commented Aug 15, 2013

wildfly-ci commented Aug 15, 2013

wildfly-ci commented Aug 15, 2013

paulrobinson commented Aug 16, 2013

wildfly-ci commented Aug 16, 2013

paulrobinson Aug 16, 2013

paulrobinson commented Aug 16, 2013

paulrobinson commented Aug 16, 2013

paulrobinson Aug 16, 2013

paulrobinson Aug 20, 2013

bstansberry Aug 20, 2013

wildfly-ci commented Aug 16, 2013

wildfly-ci commented Aug 19, 2013

wildfly-ci commented Aug 19, 2013

bstansberry commented Aug 20, 2013

paulrobinson commented Aug 20, 2013

ctomc Aug 20, 2013

ochaloup commented Aug 21, 2013

jaikiran commented Aug 22, 2013

wildfly-ci commented Aug 22, 2013

wildfly-ci commented Aug 22, 2013

paulrobinson commented Aug 26, 2013

bstansberry commented Aug 26, 2013

jaikiran Aug 27, 2013

jaikiran Aug 27, 2013

ochaloup Aug 27, 2013

wildfly-ci commented Aug 27, 2013

wildfly-ci commented Aug 27, 2013

ochaloup commented Aug 27, 2013

wildfly-ci commented Aug 27, 2013

wildfly-ci commented Aug 27, 2013

n1hility commented Aug 27, 2013

n1hility commented Aug 28, 2013

wildfly-ci commented Aug 29, 2013

wildfly-ci commented Aug 29, 2013

New XTS integration tests #4928

New XTS integration tests #4928

Conversation

ochaloup commented Aug 15, 2013

wildfly-ci commented Aug 15, 2013

wildfly-ci commented Aug 15, 2013

Failed tests

paulrobinson commented Aug 16, 2013

wildfly-ci commented Aug 16, 2013

Choose a reason for hiding this comment

paulrobinson commented Aug 16, 2013

paulrobinson commented Aug 16, 2013

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wildfly-ci commented Aug 16, 2013

wildfly-ci commented Aug 19, 2013

wildfly-ci commented Aug 19, 2013

bstansberry commented Aug 20, 2013

paulrobinson commented Aug 20, 2013

Choose a reason for hiding this comment

ochaloup commented Aug 21, 2013

jaikiran commented Aug 22, 2013

wildfly-ci commented Aug 22, 2013

wildfly-ci commented Aug 22, 2013

paulrobinson commented Aug 26, 2013

bstansberry commented Aug 26, 2013

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wildfly-ci commented Aug 27, 2013

wildfly-ci commented Aug 27, 2013

Failed tests

ochaloup commented Aug 27, 2013

wildfly-ci commented Aug 27, 2013

wildfly-ci commented Aug 27, 2013

Failed tests

n1hility commented Aug 27, 2013

n1hility commented Aug 28, 2013

wildfly-ci commented Aug 29, 2013

wildfly-ci commented Aug 29, 2013

Failed tests