[WFCORE-914] Adjust metrics to work when WFCORE-831 comes in by sett… #7991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng them to nillable A WFCORE upgrade is coming in with adjustments to the threads metrics attributes. The current usage of this in the wildfly codebase are -ejb3 (has been bumped to 4.0.0 from 3.0.0 in 9.0.1.Final) -jca (has been bumped to 4.0.0 from 3.0.0 in 9.0.1.Final) -batch (this passes in false for 'registerRuntimeOnly' so metrics do not get registered) -batch-jberet (this is new and so does not require a version bump) Similarly in this PR we have made changes to -ejb3 (see above, no bump needed) -jgroups (has been bumped to 4.0.0 from 3.0.0 in 9.0.1.Final) -messaging-activemq (this is new, and so does not require a version bump) -undertow (was 2.0.0 in 9.0.1, and has been bumped to 3.0.0 already)
…, and return undefined if we are admin-only
|
Windows Build 2918 is now running using a merge of 76cf4ef |
|
Linux Build 7877 is now running using a merge of 76cf4ef |
|
Linux Build 7877 outcome was FAILURE using a merge of 76cf4ef Failed tests |
|
Windows Build 2918 outcome was SUCCESS using a merge of 76cf4ef |
|
Windows Build 2923 is now running using a merge of 76cf4ef |
|
Linux Build 7882 is now running using a merge of 76cf4ef |
|
Linux Build 7882 outcome was SUCCESS using a merge of 76cf4ef |
|
Windows Build 2923 outcome was SUCCESS using a merge of 76cf4ef |
…works in both admin-only and normal mode
|
Windows Build 2932 is now running using a merge of 56535c7 |
|
Linux Build 7891 is now running using a merge of 56535c7 |
|
Linux Build 7891 outcome was SUCCESS using a merge of 56535c7 |
|
Windows Build 2932 outcome was SUCCESS using a merge of 56535c7 |
stuartwdouglas
added a commit
that referenced
this pull request
Aug 28, 2015
[WFCORE-914] Adjust metrics to work when WFCORE-831 comes in by sett…
|
@kabir @stuartwdouglas I messed up by pinging Kabir privately instead of commenting here. As we discussed, for many of these attributes an undefinedMetricValue should be set instead of saying they allow null. So that will need to be fixed. |
|
Ah, #8016 already does this. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ing them to nillable
A WFCORE upgrade is coming in with adjustments to the threads metrics
attributes. The current usage of this in the wildfly codebase are
-ejb3 (has been bumped to 4.0.0 from 3.0.0 in 9.0.1.Final)
-jca (has been bumped to 4.0.0 from 3.0.0 in 9.0.1.Final)
-batch (this passes in false for 'registerRuntimeOnly' so metrics do not
get registered)
-batch-jberet (this is new and so does not require a version bump)
Similarly in this PR we have made changes to
-ejb3 (see above, no bump needed)
-jgroups (has been bumped to 4.0.0 from 3.0.0 in 9.0.1.Final)
-messaging-activemq (this is new, and so does not require a version
bump)
-undertow (was 2.0.0 in 9.0.1, and has been bumped to 3.0.0 already)
With this fix, I am mostly able to do a
in both admin-only and normal modes, against the snapshot of WFCORE-831.
Mostly, because I still need to comment out https://github.com/wildfly/wildfly/blob/master/clustering/jgroups/extension/src/main/java/org/jboss/as/clustering/jgroups/subsystem/ProtocolMetricsHandler.java#L267 to get it to work. However, this is not just hit when running in admin-only mode, but also in normal mode when the server has no deployments involving clustering. The simple fix is to remove that line, but @rhusar is investigating whether that can be made more fine-grained.