Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow minimum session-id-length of 16 bytes - which is the minimum OW… #8096

Merged
merged 1 commit into from Sep 11, 2015

Conversation

rhusar
Copy link
Member

@rhusar rhusar commented Sep 10, 2015

…ASP recommendation and the EAP 6.x setting (WFLY-3642)

…ASP recommendation and the EAP 6.x setting (WFLY-3642)
@rhusar
Copy link
Member Author

rhusar commented Sep 10, 2015

Hey @stuartwdouglas, any reason why we would disallow configuring the session id length to the EAP 6.x default value or the minimum OWASP recommendation? cc @pferraro @mvinkler

@wildfly-ci
Copy link

Windows Build 3155 outcome was FAILURE using a merge of 50c38da
Summary: Execution timeout (new); tests failed: 4, passed: 1072, ignored: 290 Build time: 03:00:25

Failed tests

org.jboss.as.test.iiop.transaction.TransactionIIOPInvocationTestCase: org.jboss.as.test.iiop.basic.BasicIIOPInvocationTestCase: To disable this check and allow Arquillian to connect to a running server, set allowConnectingToRunningServer to true in the container configuration
    at org.jboss.as.arquillian.container.managed.ManagedDeployableContainer.failDueToRunning(ManagedDeployableContainer.java:309)
    at org.jboss.as.arquillian.container.managed.ManagedDeployableContainer.startInternal(ManagedDeployableContainer.java:80)
    at org.jboss.as.arquillian.container.CommonDeployableContainer.start(CommonDeployableContainer.java:110)
------- Stdout: -------
23:38:26,744 DEBUG [org.jboss.logging] (main) Logging Provider: org.jboss.logging.JBossLogManagerProvider


org.jboss.as.test.iiop.transaction.TransactionIIOPInvocationTestCase: org.jboss.as.test.iiop.client.IIOPTransactionPropagationTestCase: java.lang.RuntimeException: Arquillian has previously been attempted initialized, but failed. See cause for previous exception
To disable this check and allow Arquillian to connect to a running server, set allowConnectingToRunningServer to true in the container configuration
    at org.jboss.as.arquillian.container.managed.ManagedDeployableContainer.failDueToRunning(ManagedDeployableContainer.java:309)
    at org.jboss.as.arquillian.container.managed.ManagedDeployableContainer.startInternal(ManagedDeployableContainer.java:80)
    at org.jboss.as.arquillian.container.CommonDeployableContainer.start(CommonDeployableContainer.java:110)


org.jboss.as.test.iiop.transaction.TransactionIIOPInvocationTestCase: org.jboss.as.test.iiop.security.IIOPSecurityInvocationTestCase: java.lang.RuntimeException: Arquillian has previously been attempted initialized, but failed. See cause for previous exception
To disable this check and allow Arquillian to connect to a running server, set allowConnectingToRunningServer to true in the container configuration
    at org.jboss.as.arquillian.container.managed.ManagedDeployableContainer.failDueToRunning(ManagedDeployableContainer.java:309)
    at org.jboss.as.arquillian.container.managed.ManagedDeployableContainer.startInternal(ManagedDeployableContainer.java:80)
    at org.jboss.as.arquillian.container.CommonDeployableContainer.start(CommonDeployableContainer.java:110)


org.jboss.as.test.iiop.transaction.TransactionIIOPInvocationTestCase: java.lang.RuntimeException: Arquillian has previously been attempted initialized, but failed. See cause for previous exception
To disable this check and allow Arquillian to connect to a running server, set allowConnectingToRunningServer to true in the container configuration
    at org.jboss.as.arquillian.container.managed.ManagedDeployableContainer.failDueToRunning(ManagedDeployableContainer.java:309)
    at org.jboss.as.arquillian.container.managed.ManagedDeployableContainer.startInternal(ManagedDeployableContainer.java:80)
    at org.jboss.as.arquillian.container.CommonDeployableContainer.start(CommonDeployableContainer.java:110)


@rhusar
Copy link
Member Author

rhusar commented Sep 10, 2015

Retest this please.

@stuartwdouglas stuartwdouglas added the ready-for-merge Only for use by those with merge permissions! label Sep 11, 2015
@kabir
Copy link
Contributor

kabir commented Sep 11, 2015

Retest this please

kabir added a commit that referenced this pull request Sep 11, 2015
Allow minimum session-id-length of 16 bytes - which is the minimum OW…
@kabir kabir merged commit 603df9e into wildfly:master Sep 11, 2015
@rhusar rhusar deleted the WFLY-3642 branch September 11, 2015 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge Only for use by those with merge permissions!
Projects
None yet
4 participants