Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WFLY-9285] IIOP: Add IONA interoperability #10464

Merged
merged 1 commit into from Oct 10, 2017
Merged

[WFLY-9285] IIOP: Add IONA interoperability #10464

merged 1 commit into from Oct 10, 2017

Conversation

tadamski
Copy link
Contributor

No description provided.

@tadamski tadamski force-pushed the WFLY-9285 branch 2 times, most recently from 5326d64 to 5bb5fe9 Compare August 31, 2017 21:16
@gaol
Copy link
Contributor

gaol commented Sep 8, 2017

This is a downstream_dependency issue, so I followed and noticed that:

IIOPSubsystemTransformersTestCase.testTransformersEAP_7_0_0 failed in all 4 checks, maybe we need to update the Model version and add the transformers?

rsvoboda
rsvoboda suggested changes Oct 5, 2017
View reviewed changes
iiop-openjdk/src/main/java/org/wildfly/iiop/openjdk/IIOPRootDefinition.java Outdated
public static final AttributeDefinition INTEROP_IONA = new SimpleAttributeDefinitionBuilder(
Constants.INTEROP_IONA, ModelType.BOOLEAN, true)
.setAttributeGroup(Constants.INTEROP)
.setDefaultValue(new ModelNode(true))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be false.

@kabir kabir merged commit 9b89b67 into wildfly:master Oct 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsvoboda rsvoboda rsvoboda requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@tadamski @gaol @rsvoboda @kabir