Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WFLY-9541 Logic added by WFLY-9497 should only apply to abstract superclasses. #10648

Merged
merged 1 commit into from Nov 14, 2017
Merged

WFLY-9541 Logic added by WFLY-9497 should only apply to abstract superclasses. #10648

merged 1 commit into from Nov 14, 2017

Conversation

pferraro
Copy link
Contributor

@pferraro pferraro commented Nov 9, 2017

bstansberry
bstansberry approved these changes Nov 9, 2017
View reviewed changes
Copy link
Contributor

@bstansberry bstansberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine but fwiw my tired brain didn't process L90-91 very well today and this would have helped:

writerClass = superClass;
superClass = superClass.getSuperClass();

Feel free to ignore that though. I'm kinda groggy.

@bstansberry bstansberry added the ready-for-merge Only for use by those with merge permissions! label Nov 13, 2017
@bstansberry bstansberry merged commit 2e097f9 into wildfly:master Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bstansberry bstansberry bstansberry approved these changes

Assignees
No one assigned
Labels
ready-for-merge Only for use by those with merge permissions!
Projects
None yet
Milestone
No milestone
2 participants
@pferraro @bstansberry