Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON-P, JSON-B and JAX-RS upgrades (2nd attempt) #10843

Closed
wants to merge 8 commits into from

Conversation

asoldano
Copy link
Contributor

@asoldano asoldano commented Feb 12, 2018

This should replace #10834 and fix the jaxrs failures in that.

Overview

This PR includes changes for JSON-P, JSON-B and JAX-RS with the Java EE 8 tech preview. @stuartwdouglas please let me know if the module configurations look correct as well.

JSON-P 1.1 WFLY-6460

This replaces JSON-P 1.0 with JSON-P 1.1 when the ee8.preview.mode system property is set to true. One thing to note about this is the system property only seems to work when the user specifies it in the JAVA_OPTS. This may be because elytron accesses the module before the property is set.

Also note that in the JMS client we hard-code the version to 1.0.4 since client itself still relies on JSON-P 1.0. This library is shaded into the client which is the reason for doing this.

Also note that JSON-P 1.0 implementation library includes both the API and the implementation which is my the module.xml exports only the javax.json.* packages.

JSON-B 1.0 WFLY-7185

This introduces the new JSON-B 1.0 API. The module itself will be added to all deployments however the resource will only be added if the ee8.preview.mode system property is set to true.

There are currently not tests for JSON-B however I did test manually and I will follow up with tests after #10833 gets merged.

JAX-RS Upgrade Information

This is a preview of the upgrade that I'm soon submitting for bringing JAX-RS 2.1 RESTEasy implementation in WildFly. I'd like the reviewers to start having a look and letting me know of any additional requirements / changes needed for merging before I tag 3.5.0.Final.
I'm dealing with the needed analysis / test plan in the mean time; besides JSR 370 (JAX-RS 2.1), the RESTEasy component upgrade also pulls few other planned new features.

Few JIRA links:
https://issues.jboss.org/browse/WFLY-9789
https://issues.jboss.org/browse/WFLY-6459
https://issues.jboss.org/browse/WFLY-9786
https://issues.jboss.org/browse/WFLY-9787

Dev analysis:
wildfly/wildfly-proposals#16
wildfly/wildfly-proposals#18
wildfly/wildfly-proposals#19

@jimma
Copy link
Contributor

jimma commented Feb 12, 2018

retest this please

@kabir kabir added Feature PR provides a new feature EE8 labels Feb 12, 2018
@asoldano
Copy link
Contributor Author

rebased to solve conflict, for the records all test runs passed before.

jamezp added a commit to jamezp/wildfly that referenced this pull request Feb 12, 2018
[WFLY-7185] JSON-B 1.0 smoke test
@rsvoboda
Copy link
Contributor

Execution timeout for Elytron run.

Linux run has one failed test - failed org.jboss.as.test.clustering.cluster.web ConcurrentFineWebFailoverTestCase.testGracefulSimpleFailover. Probably related to JGroups + ISPN upgrade which was merge lately.

jamezp added a commit to jamezp/wildfly that referenced this pull request Feb 12, 2018
[WFLY-7185] JSON-B 1.0 smoke test
@jamezp
Copy link
Member

jamezp commented Feb 13, 2018

I've merged #10872 which is going to make this out of date. It includes the 2 JSON commits and the 2 JSON test commits. I'll create a new branch on my repo where I'll handle the rebase for this so that it's easier of you guys to rebase in the future. I'll leave this open for now and we can close once a new PR is opened or you can just force push to this branch.

@rsvoboda
Copy link
Contributor

This can be closed as @asoldano created #10876 for JAX-RS 2.1

@asoldano asoldano closed this Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature PR provides a new feature
Projects
None yet
5 participants