[WFLY-9821] Fix WeldProvider #10896
Merged
[WFLY-9821] Fix WeldProvider #10896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mkouba
commented
Feb 16, 2018
mkouba
commented
- prevent from incorrect initialization of SingletonProvider
- https://issues.jboss.org/browse/WFLY-9821
- prevent from incorrect initialization of SingletonProvider
|
A test is not included - the problem only occurs under special conditions. |
jamezp
reviewed
Feb 16, 2018
| @@ -58,6 +59,9 @@ static void containerShutDown(Container container) { | |||
|
|
|||
| @Override | |||
| public CDI<Object> getCDI() { | |||
| if (ModuleGroupSingletonProvider.deploymentClassLoaders.isEmpty()) { | |||
| throw new IllegalStateException(); | |||
There was a problem hiding this comment.
Will this be caught and dealt with up the call stack? My main concern is just reporting to the user what the issue actually is.
There was a problem hiding this comment.
No, this is how the contract is defined: https://github.com/cdi-spec/cdi/blob/master/api/src/main/java/javax/enterprise/inject/spi/CDIProvider.java#L34. So it's up to the javax.enterprise.inject.spi.CDI client. See also https://github.com/cdi-spec/cdi/blob/master/api/src/main/java/javax/enterprise/inject/spi/CDI.java#L60.
jamezp
approved these changes
Feb 19, 2018
jamezp
added
EE8
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.