[WFLY-9777] clean testsuite debris in git-trackable directories. #10962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
dmlloyd
approved these changes
Mar 1, 2018
stuartwdouglas
requested changes
Mar 1, 2018
| @@ -46,7 +47,7 @@ | |||
| public static JavaArchive createDeployment() { | |||
| final JavaArchive jar = ShrinkWrap.create(JavaArchive.class, MODULE_NAME + ".jar"); | |||
| jar.addPackage(UserTransactionAccessTestCase.class.getPackage()); | |||
| jar.as(ZipExporter.class).exportTo(new File(".", jar.getName()), true); | |||
| jar.as(ZipExporter.class).exportTo(new File(TestSuiteEnvironment.getTmpDir(), jar.getName()), true); | |||
There was a problem hiding this comment.
I think this like should have just been deleted, there is no reason to export the archive
| @@ -268,7 +269,7 @@ private String getClientJarPaths() throws IOException { | |||
| jar.addManifest() | |||
| .addAsManifestResource(WSTrustTestCase.class.getPackage(), "META-INF/clientKeystore.properties", "clientKeystore.properties") | |||
| .addAsManifestResource(WSTrustTestCase.class.getPackage(), "META-INF/clientstore.jks", "clientstore.jks"); | |||
| File jarFile = new File("jaxws-samples-wsse-policy-trust-client.jar"); | |||
| File jarFile = new File(TestSuiteEnvironment.getTmpDir(), "jaxws-samples-wsse-policy-trust-client.jar"); | |||
There was a problem hiding this comment.
it's used to create an URLClassLoader with these security files as resource and put into setContextClassLoader by TestWatcher, then later it retrieves back from WSTrustTestUtils static methods for client env setup.
|
Retest this please |
stuartwdouglas
approved these changes
Mar 2, 2018
|
Retest this please |
|
failed ConcurrentCoarseWebFailoverTestCase.testGracefulSimpleFailover in Windows CI does not seem related. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/WFLY-9777 clean testsuite debris in git-trackable directories.