[WFLY-10069] Remove all slf4j dependencies from WildFly #11049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR can merged after the component upgrade for wildfly-core that will incorporate wildfly/wildfly-core#3182 |
jmesnil
added
the
core-upgrade-needed
rsvoboda
suggested changes
Mar 22, 2018
| <module xmlns="urn:jboss:module:1.5" name="org.slf4j.ext"> | ||
|
|
||
| <properties> | ||
| <property name="jboss.api" value="deprecated"/> |
There was a problem hiding this comment.
This was deprecated in EAP 7.1.0.
For EAP 6.4.0 and 7.0.0 it was public module.
This cannot be removed now
There was a problem hiding this comment.
ah, it's move of slf4j stuff to wf-core, not total removal. Ignore my comment please.
https://github.com/wildfly/wildfly-core/pull/3182/files#diff-0267876148955d4bc36a55f5c9fae951R25
|
@mkouba Does Weld still use |
|
@jamezp No, it doesn't.. for a long time. |
jamezp
approved these changes
Mar 22, 2018
|
Looks like the slf4j artifacts are back again at component-matrix/pom.xml when fixing https://issues.jboss.org/browse/WFLY-9911 |
kabir
removed
the
core-upgrade-needed
|
Retest this please |
|
@jmesnil needs a rebase |
With WFCORE-3703, all SLF4J dependencies are declared in WildFly Core JIRA: https://issues.jboss.org/browse/WFLY-10069
jmesnil
force-pushed
the
WFLY-10069_slf4j_dependencies
branch
from
31346ab
to
a820451
Compare
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With WFCORE-3703, all SLF4J dependencies are declared in WildFly Core
JIRA: https://issues.jboss.org/browse/WFLY-10069