-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WFCORE-2953] Add documentation for the socket-handler on the logging subsystem. #11406
Conversation
* <<named-formatter,#named-formatter>> | ||
* <<target,#target>> | ||
A `custom-handler` allows you to define any {oracle-javadoc}/java/util/logging/Handler.html[handler] as a handler that | ||
can be assigned to a logger or aa <<async-handler,`async-handler`>>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably a typo "aa async-handler" -> "an async-handler" ?
==== Attributes | ||
The `max-backup-index` works differently on this handler than the | ||
<<size-rotating-file-handler,`size-rotating-file-handler`>>. The date suffix of the file to be rotated must be the | ||
same as the current expected suffix. For example with a suffix patter of `yyyy-MM` and a `rotate-size` of `10m` the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: "suffix patter" -> "suffix pattern"
The docs does not mention SSL/TLS TCP which is listed in the analysis doc as requirement. Maybe the docs could show an example of usage similar to the UDP one, WDYT? |
@nziakova For SSL/TLS the idea was the |
@jamezp The link should be enough, but there's no SSL/TLS example at Admin_Guide#socket-binding-groups. Maybe we only need the Elytron example for community docs? |
@jamezp I cannot find any SSL setting on the socket-binding, how do you configure it? |
@nziakova You're correct. I'll have to rework that as I misunderstood how it works. Sorry about the confusion. |
@jamezp Ah, ok. I wasn't sure if I didn't miss anything. So should the SSL config be part of the logging subsystem? In that case we will need the SSL example in the docs, I think. |
@nziakova Yes. I'm going to add an I'll also update the documentation and the analysis doc. Thanks for catching this! I made some really bad assumptions. |
@jamezp It's new to me too, I was just searching for the correct config to test it. Thanks for taking care of it! |
Docs have been updated with an SSL example. |
This is documentation for WFCORE-2953 WildFly Core PR and the proposal PR.
The first commit just cleans up the handler documentation a bit as well as remove the common_attributes document in favor of using the maven plugin configuration.