[WFLY-11003] Add documentation describing how to define an SSLContextfor SNI in the WildFly Elytron subsystem. #11659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bstansberry
added
the
Feature-Docs
jamezp
added
the
core-upgrade-needed
jamezp
reviewed
Nov 7, 2018
| @@ -1999,6 +1999,41 @@ use custom implementations of the following components: | |||
| When creating custom implementations of Elytron components, they must | |||
| present the appropriate capabilities and requirements. | |||
|
|
|||
| === Configuring SNI | |||
|
|
|||
| Using the WildFly Elytron subsystem it is possible to configure an SSL context which supports SNI. By supporting SNI if an SNI host name is available whilst the SSLSession is being negotiation a host specific SSLcontext will be selected. If no host specific SSLContext is identified either because no host name was received or because there is no match a default SSLContext will be used instead. By identifying a host specific SSLContext it means that a certificate appropriate for that host can be used. | |||
There was a problem hiding this comment.
Minor detail but
host specific SSLcontext
Should probably be SSLContext to match the rest of the case.
There was a problem hiding this comment.
also in that same clause...
s/is being negotation/is being negotiated/g
jamezp
added
rebase-this
|
@jamezp Can you please remove the 'rebase-this' label - this one is ready to go in. |
… for SNI in the WildFly Elytron subsystem.
jamezp
approved these changes
Nov 30, 2018
|
I killed the CI jobs since it's only a doc change. |
jamezp
added a commit
that referenced
this pull request
Nov 30, 2018
[WFLY-11003] Add documentation describing how to define an SSLContext for SNI in the WildFly Elytron subsystem.
jstourac
reviewed
Feb 5, 2019
|
|
||
| This example assumes that three SSLContexts have been previously defined following the steps available previously in this document, those contexts are `jboss`, `localhost`, and `wildfly`. | ||
|
|
||
| During negotiation of the SSLSession if the SNI host name received is `localhost` then the `localhost` SSLContext will be used, if the SNI host name is `wildfly.org` then the `wildfly` SSLContext will be used. If no SNI host name is received or if we receive a name that does not match this will fallback and use the `jboss` SSLContext. |
There was a problem hiding this comment.
Actually, as . (dot) character in the mapping is used as a reg-exp character, then wildfly.org will match e.g.: wildflyLorg, wildflyborg, etc., see https://issues.jboss.org/browse/WFWIP-102.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting your Pull Request!
Please make sure your PR meets the following requirements:
[WFLY-XYZ] SubjectorWFLY-XYZ Subjecthttps://issues.jboss.org/browse/WFLY-11003
This pull request is adding documentation for the SNI support added under PR: -
wildfly/wildfly-core#3513
For bigger changes, major and minor component upgrades make sure your PR also meets following requirements:
For new features ensure as well:
If you are not an active contributor of the WildFly project you can request sponsorship by one of the members to help guide you through the process.