Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFLY-11263] Validate requirement for modules previously exported by javax.ejb.api on org.jboss.as.xts #11794

Merged
merged 1 commit into from Nov 1, 2018

Conversation

yersan
Copy link
Contributor

@yersan yersan commented Oct 31, 2018

These depedencies can be removed from org.jboss.as.xts:

<module name="javax.xml.rpc.api"/>
<module name="javax.rmi.api"/>

Reasons:

  • All first level dependencies used by wildfly-xts.jar are accesible by the other depended-on modules
  • wildfly-xts does not load a service from any of its dependencies using ServiceLoading
  • There are not DUPs enabling any external configuration for resources exported by the removed modules.

Jira issue: https://issues.jboss.org/browse/WFLY-11263
CC @ochaloup

@bstansberry
Copy link
Contributor

@ochaloup Please approve.

@ochaloup
Copy link
Contributor

yes, approving. This is fine from my point of view.

@kabir kabir merged commit 226f754 into wildfly:master Nov 1, 2018
@yersan yersan deleted the subtask-WFLY-6966/WFLY-11263 branch February 12, 2019 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants