[WFLY-10712] Observability: MicroProfile Metrics #11830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rsvoboda fiy I've squashed all the commits from the dev branch in a single commit The community documentation is in progress, I'll add it a commit later. |
jmesnil
added
Feature
jmesnil
force-pushed
the
WFLY-10712_microprofile_metrics-smallrye
branch
from
f410f9a
to
a81f923
Compare
bstansberry
requested changes
Nov 11, 2018
...rye/src/main/java/org/wildfly/extension/microprofile/metrics/MetricsRegistrationService.java
Outdated
Show resolved
Hide resolved
...rye/src/main/java/org/wildfly/extension/microprofile/metrics/MetricsRegistrationService.java
Outdated
Show resolved
Hide resolved
.../java/org/wildfly/extension/microprofile/metrics/MicroProfileMetricsSubsystemDefinition.java
Outdated
Show resolved
Hide resolved
...main/java/org/wildfly/extension/microprofile/metrics/MicroProfileMetricsSubsystemRemove.java
Outdated
Show resolved
Hide resolved
...main/java/org/wildfly/extension/microprofile/metrics/_private/MicroProfileMetricsLogger.java
Outdated
Show resolved
Hide resolved
...dules/system/layers/base/org/wildfly/extension/microprofile/metrics-smallrye/main/module.xml
Outdated
Show resolved
Hide resolved
jmesnil
force-pushed
the
WFLY-10712_microprofile_metrics-smallrye
branch
2 times, most recently
from
9ae5f13
to
a73a01c
Compare
bstansberry
approved these changes
Nov 12, 2018
jmesnil
force-pushed
the
WFLY-10712_microprofile_metrics-smallrye
branch
from
a73a01c
to
5c6cbe5
Compare
|
I played a bit with this at home yesterday before going to bed and I noticed issues in docs. I just created https://issues.jboss.org/browse/WFWIP-150. |
jmesnil
force-pushed
the
WFLY-10712_microprofile_metrics-smallrye
branch
from
5c6cbe5
to
f89b5f5
Compare
jamezp
reviewed
Nov 13, 2018
| @MessageLogger(projectCode = "WFLYMETRICS", length = 4) | ||
| public interface MicroProfileMetricsLogger extends BasicLogger { | ||
| /** | ||
| * A logger with the category {@code org.wildfly.extension.batch}. |
There was a problem hiding this comment.
Not a big deal, but we might want to change the category name here.
...le/metrics-smallrye/src/main/resources/subsystem-templates/microprofile-metrics-smallrye.xml
Show resolved
Hide resolved
jamezp
approved these changes
Nov 13, 2018
jmesnil
force-pushed
the
WFLY-10712_microprofile_metrics-smallrye
branch
from
6b834f2
to
1f9b163
Compare
Add microprofile-metrics-smallrye extension to provide support for MicroProfile Metrics 1.1 * integrate smallrye-metrics:1.1.2 that implements MicroProfile Metrics 1.1 * provide the /metrics HTTP endpoint on the management interface * The extension is added to standalone profiles only (not available in domain mode) Dev analysis: wildfly/wildfly-proposals#147 JIRA: https://issues.jboss.org/browse/WFLY-10712
* Add documentation in the admin guide. JIRA: https://issues.jboss.org/browse/WFLY-10712
This ensures that the deployment will be considered complete once Batch jobs services have been properly installed.
jmesnil
force-pushed
the
WFLY-10712_microprofile_metrics-smallrye
branch
from
1f9b163
to
1e7b236
Compare
kabir
removed
the
missing-reqs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add microprofile-metrics-smallrye extension to provide support for
MicroProfile Metrics 1.1
1.1
domain mode)
Dev analysis: wildfly/wildfly-proposals#147
JIRA: https://issues.jboss.org/browse/WFLY-10712