[WFLY-11543] Server-side services outside the transactions subsystem should not use ContextTransactionSynchronizationRegistry #11961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bstansberry
force-pushed
the
WFLY-11543
branch
from
db06e71
to
8a973b1
Compare
jamezp
approved these changes
Dec 21, 2018
|
@kabir was able to produce a manual reproducer of the issue and this change fixes it, so I'll merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/WFLY-11543
Server-side services need to use the TSR provided as an MSC Service by the transaction subsystem, as it provides important synchronization ordering behavior that direct use of ContextTransactionSynchronizationRegistry bypasses.
Note that this PR at this point is NOT necessarily a fix for this issue. It's a possible fix, and is definitely something we regard as the correct thing to do, but we are not certain this problem is the WFLY-11543 problem.