WFLY-11575 DefaultCacheContainer getCache(...) createIfAbsent variants throw NPE... #11988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s throw NPE when called with false and cache does not exist
bstansberry
approved these changes
Jan 9, 2019
11 tasks
blaghed
reviewed
Jan 9, 2019
| } | ||
|
|
||
| @Deprecated | ||
| @Override | ||
| public <K, V> Cache<K, V> getCache(String cacheName, String configurationTemplate, boolean createIfAbsent) { | ||
| return this.wrap(this.cm.<K, V>getCache(cacheName, configurationTemplate, createIfAbsent)); | ||
| Cache<K, V> cache = this.cm.<K, V>getCache(cacheName, configurationTemplate, createIfAbsent); | ||
| return (cache != null) ? this.wrap(cache) : null; |
There was a problem hiding this comment.
Wouldn't it be better to check this in the "wrap" method?
With this approach you are assuming implicit behaviour on the delegate manager.
There was a problem hiding this comment.
getCache(...) can only return null in the createIfAbsent variants.
There was a problem hiding this comment.
But... aren't you inferring that knowledge by assuming how "cm" works?
Well, its your project, and this does fix the issue for me, so I'll not argue 👍
There was a problem hiding this comment.
But... aren't you inferring that knowledge by assuming how "cm" works?
This behavior is explicitly defined in the EmbeddedCacheManager contract. As an implementor (via decoration) of that contract, this knowledge is to be expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…when called with false and cache does not exist
https://issues.jboss.org/browse/WFLY-11575
Supersedes #11985