[WFLY-9450] NPE on jaxrs subsystem of FAILED deployment #12022
Conversation
| @@ -184,7 +184,9 @@ public void execute(OperationContext context, ModelNode operation) throws Operat | |||
| UndertowService.deploymentServiceName(server, host, contextPath)); | |||
| final UndertowDeploymentService deploymentService = (UndertowDeploymentService) controller.getService(); | |||
| try { | |||
|
|
|||
| if(deploymentService.getDeployment() == null) { | |||
| return; | |||
There was a problem hiding this comment.
Just returning here bypasses the catch block. Which is good in that writing to the server log, with a stack trace, is not good in this situation. OTOH it also bypasses the context.addResponseWarning in that catch block, so the user doesn't get the expected result but also gets no feedback as to why.
I can live with that though; I expect there are many other similar cases.
There was a problem hiding this comment.
Hmm I will give it another spin and see if it can do better withought drawbacks.
bstansberry
dismissed
their stale review
@baranowb I'm removing my "Approved" review based on the discussion above. I don't want this to get merged by mistake while you're making changes. I'm fine though with merging this as is if you want to make any change later. If you want that, please just ping me and we'll make it happen. Thanks!
|
Closing as #12731 has been merged and contains the fixes from here |
Issue: https://issues.jboss.org/browse/WFLY-9450