[WFLY-11813] Test for empty username for Elytron's FormAuthenticationMechanism #12125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
spriadka
changed the title
|
@spriadka could you squash commits? Otherwise seems good to me. |
|
The commit messages should also reference the WFLY Jira issue. |
…cationMechanism + additional minor refactoring
spriadka
force-pushed
the
tests-for-empty-username-http-form-elytron
branch
from
f614959
to
335a0b5
Compare
darranl
reviewed
Apr 11, 2019
| import org.apache.http.util.EntityUtils; | ||
| import org.junit.Test; | ||
|
|
||
| import static org.apache.http.HttpStatus.SC_FORBIDDEN; |
There was a problem hiding this comment.
The import order is wrong on this one, statics should come first.
|
@spriadka Are you able to get the imports corrected and then we can look to get this merged? |
|
Resolved via #12744, which just corrected the import order here. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FormMechTestCase#testEmptyUsername()could be added toFormMechTestBase, however I'm not sure if it is within desired scope of other test classes extendingFormMechTestBase