[WFLY-11787] Test checks if the identity sets by HttpServletRequest.login() is propagated into the secured EJB. #12131
Conversation
|
Retest this please |
|
@spyrkob Could you please review this PR? |
…ogin() is propagated into the secured EJB.
dcihak
force-pushed
the
upstream-WFLY-11787
branch
from
8ce7900
to
b5316c8
Compare
|
Can we merge this? |
|
I'm not sure, but I think the HelloBean will be called locally rather than remotely in the test, so the fix won't actually get tested. |
|
@dcihak Were you able to verify that the test fails before the identity propagation changes (i.e., before Elytron 1.8.0.Final) and passes after? |
| servletElytronDomainSetup.setup(managementClient, containerId); | ||
|
|
||
| // /subsystem=elytron/sasl-authentication-factory=auth-test:add(sasl-server-factory=configured,security-domain=auth-test,mechanism-configurations=[{mechanism-name=BASIC}]) | ||
| ModelNode addSaslAuthentication = createOpNode("subsystem=elytron/sasl-authentication-factory=" + getSecurityDomainName(), ADD); |
There was a problem hiding this comment.
Really I think it would be nice to get all of these operations into org.wildfly.test.security.common.AbstractElytronSetupTask to create ConfigurableElement instances so the same resources can be created for further test cases.
That is probably a task outside this PR as it looks like we also need to update AbstractElytronSetupTask to also extend SnapshotRestoreSetupTask or at least make use of that in the tests so the setup tasks can avoid deleting resources.
wildfly-ci
added
the
deps-ok
| @@ -0,0 +1,6 @@ | |||
| package org.jboss.as.test.integration.web.security.identity.propagation.deployment; | |||
| @@ -0,0 +1,17 @@ | |||
| package org.jboss.as.test.integration.web.security.identity.propagation.deployment; | |||
|
I am going to close this one as it has had no updates since the original questions were asked, please feel free to either re-open or send in a new PR with the details requested. |
Upstream JIRA issue: https://issues.jboss.org/browse/WFLY-11787
Test configures Elytron to use Identity Propagation.
Test deploys application with the secured servlet and checks if the identity sets by HttpServletRequest.login() is propagated into the secured EJB.