[WFLY-11759] Exclude problematic Undertow interfaces from ServiceLoader calls when testing management model transformation #12367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KernelServicesBuilder.excludeResourceFromParent API is no longer needed, the test runs okay
…er calls when testing management model transformation
|
Tests of this in combination with the proposed Undertow upgrade in core (wildfly/wildfly-core#3820): |
wildfly-ci
added
the
deps-ok
This was referenced Jun 18, 2019
kabir
reviewed
Jun 18, 2019
| <!--<access-log directory="${jboss.server.server.dir}" pattern="REQ %{i,test-header}" predicate="not path-suffix(*.css)" prefix="access" rotate="false"/>--> | ||
| <access-log directory="${jboss.server.server.dir}" pattern="REQ %{i,test-header}" prefix="access" rotate="false"/> | ||
| <access-log directory="${jboss.server.server.dir}" pattern="REQ %{i,test-header}" predicate="not path-suffix(*.css)" prefix="access" rotate="false"/> | ||
| <!-- <access-log directory="${jboss.server.server.dir}" pattern="REQ %{i,test-header}" prefix="access" rotate="false"/> --> |
There was a problem hiding this comment.
Can't this one simply be removed? The other line seems to contain everything and more
There was a problem hiding this comment.
This commit isn't mine, it's from #12363 so I don't want to change it.
There was a problem hiding this comment.
@kabir good catch, I'll submit a new PR to remote those, sorry for the mistake
kabir
approved these changes
Jun 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also reverts #12098 which was a workaround pending this solution.
https://issues.jboss.org/browse/WFLY-11759