Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WFLY-12265 Warning when singleton EJB implements SessionBean interface #12460

Merged
merged 1 commit into from Aug 20, 2019
Merged

WFLY-12265 Warning when singleton EJB implements SessionBean interface #12460

merged 1 commit into from Aug 20, 2019

Conversation

TomasHofman
Copy link
Contributor

@wildfly-ci wildfly-ci added the deps-ok Dependencies have been checked, and there are no significant changes label Jul 30, 2019
@TomasHofman
Copy link
Contributor Author

Looks test case is failing with security manager.

chengfang
chengfang suggested changes Aug 2, 2019
View reviewed changes
Copy link
Contributor

@chengfang chengfang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the warning message should indicate that implementing SessionBean interface is ignored (the action taken by ejb container), and what the application should do to fix it (remove the implement SessionBean clause).

@TomasHofman
Copy link
Contributor Author

@chengfang I updated the message to:

[EJB3.2 spec, section 4.9.2] Singleton session beans are not allowed to implement 'javax.ejb.SessionBean' interface. This interface on bean '%s' is going to be ignored and should be removed.

@jamezp jamezp added the rebase-this PR has a merge conflict. label Aug 9, 2019
@TomasHofman
Copy link
Contributor Author

Rebased.

@bstansberry bstansberry added ready-for-merge Only for use by those with merge permissions! and removed rebase-this PR has a merge conflict. labels Aug 20, 2019
@bstansberry bstansberry mentioned this pull request Aug 20, 2019
Closed
@bstansberry bstansberry merged commit 0e13252 into wildfly:master Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chengfang chengfang chengfang approved these changes

Assignees
No one assigned
Labels
deps-ok Dependencies have been checked, and there are no significant changes ready-for-merge Only for use by those with merge permissions!
Projects
None yet
Milestone
No milestone
5 participants
@TomasHofman @chengfang @bstansberry @jamezp @wildfly-ci