Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WFLY-12165 Expose management metrics for HotRod caches #12461

Merged
merged 14 commits into from Sep 3, 2019
Merged

WFLY-12165 Expose management metrics for HotRod caches #12461

merged 14 commits into from Sep 3, 2019

Conversation

pferraro
Copy link
Contributor

@bstansberry bstansberry added Feature PR provides a new feature missing-reqs Features missing one or more of the pre-merge requirements labels Jul 30, 2019
@wildfly-ci wildfly-ci added the deps-ok Dependencies have been checked, and there are no significant changes label Jul 30, 2019
@pferraro pferraro force-pushed the hotrod branch 3 times, most recently from 6f67f86 to 06001ac Compare August 6, 2019 11:47
@pferraro pferraro force-pushed the hotrod branch 6 times, most recently from a57fe4f to 2201f83 Compare August 19, 2019 21:38
@jamezp jamezp added missing-reqs Features missing one or more of the pre-merge requirements and removed missing-reqs Features missing one or more of the pre-merge requirements labels Aug 20, 2019
jamezp
jamezp reviewed Aug 22, 2019
View reviewed changes
Copy link
Member

@jamezp jamezp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add some transformer tests to this for the new attribute.

...jboss/as/clustering/infinispan/subsystem/remote/InvalidationNearCacheResourceDefinition.java Show resolved Hide resolved
@pferraro
Copy link
Contributor Author

pferraro commented Aug 22, 2019 •
edited

We should add some transformer tests to this for the new attribute.

The trivial conversion is already covered, but I'll make sure this is covered by the rejection tests. Done.

@pferraro
Add convenience methods to create the ServiceName using a given capab…
3d2c825 
…ility name resolver.
@pferraro
Add method for supplying parameters to an operation.
f43631c
@pferraro
Don't allocate new strings for common attribute names.
68119f8
@pferraro
max-entries should be optional.
f5f875c
@pferraro
Eliminate ResourceServiceConfiguratorFactory lambdas.
63b0521
@pferraro
Don't assume a specific RemoteCache implementation.
65a19e1
@pferraro
RemoteCache decorator that registers on start() and closes registrati…
2267df0 
…on on stop().
@pferraro
Expose RemoteCacheManagerMXBean from RemoteCacheContainer.
2b9897c
@pferraro
Encapsulate remote cache creation in a service.
cc14010
@pferraro
WFLY-12165 Expose management metrics and runtime operations for HotRo…
1480e15 
…d cache managers and caches
@pferraro
Add management operation to switch the remote-cluster to which a hotr…
0c36b52 
…od client communicates.
@pferraro
Consolidate Offloading_session_state_to_remote_Infinispan_server_clus…
388b752 
…ter docs into Infinispan subsystem docs.
tommaso-borgato
tommaso-borgato approved these changes Aug 28, 2019
View reviewed changes
Copy link
Contributor

@tommaso-borgato tommaso-borgato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks in sync with TP

.../java/org/jboss/as/test/clustering/cluster/web/remote/AbstractHotRodWebFailoverTestCase.java
result = execute(this.client3, readResource);
Assert.assertEquals(0L, result.get("hits").asLong());
Assert.assertEquals(0L, result.get("writes").asLong());
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pferraro test sequence is:

response = client.execute(new HttpGet(uri1));
response = client.execute(new HttpGet(uri2));
response = client.execute(new HttpGet(uri3));

lifecycle.stop(NODE_1);

response = client.execute(new HttpGet(uri2));
response = client.execute(new HttpGet(uri2));
response = client.execute(new HttpGet(uri3));
response = client.execute(new HttpGet(uri3));

lifecycle.start(NODE_1);

response = client.execute(new HttpGet(uri2));
response = client.execute(new HttpGet(uri2));
response = client.execute(new HttpGet(uri3));

lifecycle.stop(NODE_2);

response = client.execute(new HttpGet(uri1));
response = client.execute(new HttpGet(uri1));
response = client.execute(new HttpGet(uri3));
response = client.execute(new HttpGet(uri3));

lifecycle.start(NODE_2);

response = client.execute(new HttpGet(uri1));
response = client.execute(new HttpGet(uri1));

hence, NODE_2 never gets hit after restart: that's the reason why it's statistics remain at 0, correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct.

@jamezp jamezp removed the missing-reqs Features missing one or more of the pre-merge requirements label Aug 28, 2019
@kabir
Copy link
Contributor

kabir commented Aug 31, 2019

Retest this please

@kabir
Copy link
Contributor

kabir commented Aug 31, 2019

@tommaso-borgato @pferraro Am I reading it right that if this passes it can be merged?

@bstansberry bstansberry merged commit 264d864 into wildfly:master Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bstansberry bstansberry bstansberry left review comments

@jamezp jamezp jamezp left review comments

@tommaso-borgato tommaso-borgato tommaso-borgato approved these changes

Assignees
No one assigned
Labels
deps-ok Dependencies have been checked, and there are no significant changes Feature PR provides a new feature
Projects
None yet
Milestone
No milestone
6 participants
@pferraro @kabir @bstansberry @jamezp @tommaso-borgato @wildfly-ci