[WFLY-12563] org.jboss.jbossfaces.WAR_BUNDLES_JSF_IMPL flag ignored w… #12714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wildfly-ci
added
the
deps-ok
|
@fjuma Please review. |
|
@tmiyargi Thanks for working on this! The fix looks ok. Did you do a quick sanity test just to make sure this doesn't re-introduce the problem from https://issues.jboss.org/browse/WFLY-10796? (I don't think it will but it's good to make sure.) The failure that happens in |
…hen WARs are embedded in EAR
|
@fjuma thanks, PR updated and included testing for that https://issues.jboss.org/browse/WFLY-10796 |
fjuma
approved these changes
Oct 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…hen WARs are embedded in EAR
Issue: https://issues.jboss.org/browse/WFLY-12563