[WFLY-13086] Upgrade gson from 2.8.2 to 2.8.6 #12987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ehsavoie could you review please? |
wildfly-ci
added
the
deps-ok
|
Jaeger client is on 2.8.6. Why not going all the way to 2.8.6 ? |
|
@ehsavoie I was going by downstream version, if it's OK to go to most recent version I can update the PR |
|
@spyrkob Please go to 2.8.6. The only use of this lib is Jaeger and the pom of the 0.34.3 version we use specifies 2.8.6 so WF should match. |
spyrkob
changed the title
bstansberry
approved these changes
Feb 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/WFLY-13086
Downstream dependency to align with Runtimes versions
Changes: google/gson@gson-parent-2.8.2...gson-parent-2.8.5