Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WFLY-13255] Upgrade Apache wss4j to 2.2.5 #13125

Merged
merged 1 commit into from Mar 20, 2020
Merged

[WFLY-13255] Upgrade Apache wss4j to 2.2.5 #13125

merged 1 commit into from Mar 20, 2020

Conversation

spyrkob
Copy link
Contributor

@spyrkob spyrkob commented Mar 18, 2020

Issue: https://issues.redhat.com/browse/WFLY-13255

Update wss4j to version in line with Cryptacular 1.2.4

@spyrkob
Copy link
Contributor Author

spyrkob commented Mar 18, 2020

@jimma could you review please?

@wildfly-ci wildfly-ci added the deps-ok Dependencies have been checked, and there are no significant changes label Mar 18, 2020
@jimma
Copy link
Contributor

jimma commented Mar 18, 2020

@spyrkob Can we please upgrade these components too ?
jasypt 1.9.2 -> 1.9.3
opensaml 3.3.0 -> 3.3.1

@spyrkob
Copy link
Contributor Author

spyrkob commented Mar 18, 2020

@jimma updated the PR with the other component upgrades. Are those related to Cryptacular update as well?

@jimma
Copy link
Contributor

jimma commented Mar 18, 2020

@spyrkob wss4j 2.2.5 upgraded these versions, so we should upgrade them in WFLY.

bstansberry
bstansberry approved these changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@bstansberry bstansberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving based on the previous comments.

@bstansberry bstansberry merged commit 0429521 into wildfly:master Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bstansberry bstansberry bstansberry approved these changes

Assignees
No one assigned
Labels
deps-ok Dependencies have been checked, and there are no significant changes
Projects
None yet
Milestone
No milestone
4 participants
@spyrkob @jimma @bstansberry @wildfly-ci