Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFLY-13392] WFSM000001: Permission check failed ... FilePermission when Security Manager enabled and Web App tries to forward to jsp #13232

Merged
merged 1 commit into from Jun 17, 2020

Conversation

gaol
Copy link
Contributor

@gaol gaol commented Apr 22, 2020

@wildfly-ci wildfly-ci added the deps-ok Dependencies have been checked, and there are no significant changes label Apr 22, 2020
@gaol gaol force-pushed the WFLY-13392-test branch 2 times, most recently from 51cdcb1 to f4bce0c Compare April 23, 2020 02:50
@gaol gaol marked this pull request as ready for review May 19, 2020 06:20
@gaol
Copy link
Contributor Author

gaol commented May 19, 2020

retest this please

Copy link
Contributor

@darranl darranl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also please have a meaningful commit message and title to the pull request.

When coming back in 5 years time it is frustrating to look through the history of a class to understand the intent to be confronted with a list of "Test for WFLY-111", "Fix for AS7-654", "Update for WFL-222".

The commit message just needs to be the Jira issue plus a short sentence which is a summary of the change. The title of the PR should also be updated so we have a better idea of what this covers so we know who to ask for review.

…hen Security Manager enabled and Web App tries to forward to jsp

The issue was fixed by upgrading undertow to 2.1.1.Final (https://issues.redhat.com/browse/UNDERTOW-1703)

This is the test for WFLY-13392
@gaol gaol changed the title Tests for WFLY-13392 [WFLY-13392] WFSM000001: Permission check failed ... FilePermission when Security Manager enabled and Web App tries to forward to jsp May 20, 2020
@gaol
Copy link
Contributor Author

gaol commented May 20, 2020

@darranl Updated as required. Thanks :)

@darranl darranl dismissed their stale review May 20, 2020 07:42

Requested changes applied.

@ivassile
Copy link
Contributor

@darranl This change is scheduled for EAP 7.3.2. Can you please merge it upstream? Thanks!

@darranl darranl added the ready-for-merge Only for use by those with merge permissions! label Jun 15, 2020
@darranl
Copy link
Contributor

darranl commented Jun 15, 2020

@ivassile I am not planning to be merging today but have added the approval so upstream is ready to go.

@bstansberry bstansberry mentioned this pull request Jun 17, 2020
@bstansberry bstansberry merged commit 6834b65 into wildfly:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps-ok Dependencies have been checked, and there are no significant changes ready-for-merge Only for use by those with merge permissions!
Projects
None yet
5 participants