WFLY-10612 Include EJB's IIOP Binding when EJB is deployed logging #13238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wildfly-ci
added
the
deps-ok
bstansberry
reviewed
Apr 23, 2020
| * A logger with the category {@code org.jboss.as.ejb3.iiop} used for deployment | ||
| * log messages | ||
| */ | ||
| EjbLogger IIOP_DEPLOYMENT_LOGGER = Logger.getMessageLogger(EjbLogger.class, "org.jboss.as.ejb3.iiop"); |
There was a problem hiding this comment.
This should just use DEPLOYMENT_LOGGER.
There was a problem hiding this comment.
Thanks, Brian. I have changed accordingly.
|
@chengfang or @tadamski Please review. |
chengfang
reviewed
Apr 28, 2020
|
|
||
| @LogMessage(level = INFO) | ||
| @Message(id = 516, value = "IIOP bindings for session bean named '%s' in deployment unit '%s' are as follows: %s") | ||
| void iiopBindings(final String ComponentName, final String ModuleName, String Name); |
There was a problem hiding this comment.
Just some minor style issues: either use final for all 3 params or no final.
ComponentName -> componentName, the same for other 2 params.
chengfang
approved these changes
Apr 30, 2020
bstansberry
added
the
ready-for-merge
Closed
|
Thanks @RanabirChakraborty ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/WFLY-10612