WFLY-11767 Remove unused dependencies from org.jboss.as.connector #13328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wildfly-ci
added
the
deps-ok
|
@maeste Any concerns? The org.jboss.jts module provides org.jboss.narayana.jts:narayana-jts-idlj and none of the packages in that artifact are used by org.wildfly:wildfly-connector. The org.jboss.narayana.jts:narayana-jts-idlj artifact's META-INF/services has an entry for the CDI Extension interface, but that's not something org.wildfly:wildfly-connector would be loading. So this looks unused to me. |
|
@bstansberry LGTM |
bstansberry
added
the
ready-for-merge
|
Thanks @RanabirChakraborty. JIRA isn't working for me right now so please check back on the JIRA and resolve it if it remains unresolved. |
|
Thank you! @bstansberry I have marked it as Resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/WFLY-11767