[WFLY-13647] Annotation processing error sun.reflect.annotation.TypeNotPresentExceptionProxy does not indicate issue #13399
Conversation
wildfly-ci
added
the
deps-ok
|
@chengfang or @tadamski or @fl4via please review. |
| } catch (ArrayStoreException e) { | ||
| // https://bugs.openjdk.java.net/browse/JDK-7183985 | ||
| // Class.findAnnotation() has a bug under JDK < 11 which throws ArrayStoreException | ||
| throw EjbLogger.ROOT_LOGGER.missingClassInAnnotation(annotation.getSimpleName(), iface.getName()); |
There was a problem hiding this comment.
I suspect we don't need exception handling here. When @Remote @Local is used in a business interface, they do not take any arguments. The no-arg annotation is to indicate that the annotated business interface is a local or remote business interface. For ex,
@Remote
public interface Calculator {...}There was a problem hiding this comment.
I think it should be good if users do it in correct way(like they should package classes referred by the annotation). :)
but what happens if users referred some classes in the business interfaces' Remote annotation by mistake? is it still a valid deployment?
There was a problem hiding this comment.
If @Remote or @Local on business interface has param, then it's an application's error, though the spec does not say what should happen in this case. WildFly just ignores the param, which happens after the annotation processing. So to tolerate this type of user errors, it's okay to keep this checking.
bstansberry
added
the
ready-for-merge
|
@chengfang This needs a conflict resolved. |
|
@gaol can you update your local repo and increment the log id in The failure in Windows JDK11 seem unrelated intermittent failure. I just created WFLY-13682 (JBossWSStringReplaceTestCase.incorrectValueOfModifyWsdlAddressOpeningElement failed intermittently on Windows) to track it separately. |
…otPresentExceptionProxy does not indicate issue - Fix case of missing classes referenced by HandlesTypes in ServletContainerInitializer Signed-off-by: Lin Gao <lgao@redhat.com>
…otPresentExceptionProxy does not indicate issue - Fix case of missing classes referenced by Remote or Local in session bean Signed-off-by: Lin Gao <lgao@redhat.com>
|
@chengfang Thanks for the instructions, I just updated the PR to fix the conflicts. :) |
|
Linux JDK8 and Linux JDK11 jobs failed on July 20, 2020, with 12 failures in WFLY-12649 |
[WFLY-13647] Annotation processing error sun.reflect.annotation.TypeNotPresentExceptionProxy does not indicate issue
Issue: https://issues.redhat.com/browse/WFLY-13647
There is a bug with
Class.getAnnotation()call inJDK < 11[1] which throwsArrayStoreExceptionwhen the annotation refers to some classes not found in current class path. TheArrayStoreExceptionconfuses user why it failed because the root cause is missing.This PR tries to catch the exception and give more readable feedback in this case.
[1] https://bugs.openjdk.java.net/browse/JDK-7183985