Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WFLY-13739] WeldJpaInjectionTestCase fails in the jpa layer test suite #13456

Merged
merged 1 commit into from Aug 5, 2020
Merged

[WFLY-13739] WeldJpaInjectionTestCase fails in the jpa layer test suite #13456

merged 1 commit into from Aug 5, 2020

Conversation

yersan
Copy link
Contributor

@yersan yersan commented Aug 4, 2020

@wildfly-ci wildfly-ci added the deps-ok Dependencies have been checked, and there are no significant changes label Aug 4, 2020
@yersan
Copy link
Contributor Author

yersan commented Aug 4, 2020

Closing this for further investigation. The error in a local tests is different than the error on TC.

@yersan yersan closed this Aug 4, 2020
@yersan yersan deleted the bugs/WFLY-13739 branch August 4, 2020 10:07
@yersan yersan restored the bugs/WFLY-13739 branch August 4, 2020 11:39
@yersan yersan deleted the bugs/WFLY-13739 branch August 4, 2020 11:40
@yersan yersan restored the bugs/WFLY-13739 branch August 4, 2020 11:40
@yersan yersan reopened this Aug 4, 2020
@yersan
Copy link
Contributor Author

yersan commented Aug 5, 2020

retest this please

bstansberry
bstansberry approved these changes Aug 5, 2020
View reviewed changes
Copy link
Contributor

@bstansberry bstansberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, so even though BV is not needed this change is needed in order to bring in CDI.

@bstansberry bstansberry added the ready-for-merge Only for use by those with merge permissions! label Aug 5, 2020
@yersan
Copy link
Contributor Author

yersan commented Aug 5, 2020

@bstansberry right

@bstansberry bstansberry mentioned this pull request Aug 5, 2020
Closed
@bstansberry bstansberry merged commit 2e355bb into wildfly:master Aug 5, 2020
@yersan yersan deleted the bugs/WFLY-13739 branch August 6, 2020 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bstansberry bstansberry bstansberry approved these changes

@darranl darranl darranl approved these changes

Assignees
No one assigned
Labels
deps-ok Dependencies have been checked, and there are no significant changes ready-for-merge Only for use by those with merge permissions!
Projects
None yet
Milestone
No milestone
4 participants
@yersan @bstansberry @darranl @wildfly-ci