Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WFLY-13716] Integration tests for Elytron failover-realm #13484

Merged
merged 1 commit into from Sep 17, 2020
Merged

[WFLY-13716] Integration tests for Elytron failover-realm #13484

merged 1 commit into from Sep 17, 2020

Conversation

OndrejKotek
Copy link
Contributor

@OndrejKotek OndrejKotek commented Aug 13, 2020 •
edited

@wildfly-ci wildfly-ci added the deps-ok Dependencies have been checked, and there are no significant changes label Aug 13, 2020
@OndrejKotek
Copy link
Contributor Author

@darranl @fjuma @nekdozjam @jstourac Can you review this one please?

@bstansberry
Copy link
Contributor

/retest

@bstansberry
Copy link
Contributor

@OndrejKotek It looks like the test needs to be modified to work properly on windows:

15:58:10,698 ERROR [org.jboss.msc.service.fail] (MSC service thread 1-3) MSC000001: Failed to start service org.wildfly.security.security-event-listener.audit_log_for_failover_realm: org.jboss.msc.service.StartException in service org.wildfly.security.security-event-listener.audit_log_for_failover_realm: Failed to start service
	at org.jboss.msc@1.4.11.Final//org.jboss.msc.service.ServiceControllerImpl$StartTask.execute(ServiceControllerImpl.java:1731)
	at org.jboss.msc@1.4.11.Final//org.jboss.msc.service.ServiceControllerImpl$ControllerTask.run(ServiceControllerImpl.java:1559)
	at org.jboss.threads@2.4.0.Final//org.jboss.threads.ContextClassLoaderSavingRunnable.run(ContextClassLoaderSavingRunnable.java:35)
	at org.jboss.threads@2.4.0.Final//org.jboss.threads.EnhancedQueueExecutor.safeRun(EnhancedQueueExecutor.java:1990)
	at org.jboss.threads@2.4.0.Final//org.jboss.threads.EnhancedQueueExecutor$ThreadBody.doRunTask(EnhancedQueueExecutor.java:1486)
	at org.jboss.threads@2.4.0.Final//org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1377)
	at java.base/java.lang.Thread.run(Thread.java:834)
Caused by: java.nio.file.InvalidPathException: Illegal char <&amp#12;> at index 16: C:BuildAgentwork&amp#12;5da3564a57e9d74testsuiteintegrationelytrontargetely-audit_log_for_failover_realm10802728281000877250audit.log
	at java.base/sun.nio.fs.WindowsPathParser.normalize(WindowsPathParser.java:182)
	at java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:153)
	at java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:77)
	at java.base/sun.nio.fs.WindowsPath.parse(WindowsPath.java:92)
	at java.base/sun.nio.fs.WindowsFileSystem.getPath(WindowsFileSystem.java:229)
	at java.base/java.io.File.toPath(File.java:2292)
	at org.wildfly.extension.elytron@13.0.0.Beta5//org.wildfly.extension.elytron.AuditResourceDefinitions$1$1.get(AuditResourceDefinitions.java:244)
	at org.wildfly.extension.elytron@13.0.0.Beta5//org.wildfly.extension.elytron.AuditResourceDefinitions$1$1.get(AuditResourceDefinitions.java:231)
	at org.wildfly.extension.elytron@13.0.0.Beta5//org.wildfly.extension.elytron.TrivialService.start(TrivialService.java:53)
	at org.jboss.msc@1.4.11.Final//org.jboss.msc.service.ServiceControllerImpl$StartTask.startService(ServiceControllerImpl.java:1739)
	at org.jboss.msc@1.4.11.Final//org.jboss.msc.service.ServiceControllerImpl$StartTask.execute(ServiceControllerImpl.java:1701)
	... 6 more

@OndrejKotek OndrejKotek force-pushed the WFLY-13716-test branch 2 times, most recently from bc20555 to 379aede Compare September 11, 2020 09:10
@OndrejKotek
Copy link
Contributor Author

@bstansberry I have updated the test case, it works properly now.

@darranl darranl added the ready-for-merge Only for use by those with merge permissions! label Sep 16, 2020
@darranl darranl mentioned this pull request Sep 16, 2020
Closed
@bstansberry bstansberry merged commit 50b768c into wildfly:master Sep 17, 2020
@OndrejKotek OndrejKotek deleted the WFLY-13716-test branch June 6, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstourac jstourac jstourac left review comments

@fjuma fjuma fjuma approved these changes

Assignees
No one assigned
Labels
deps-ok Dependencies have been checked, and there are no significant changes ready-for-merge Only for use by those with merge permissions!
Projects
None yet
Milestone
No milestone
6 participants
@OndrejKotek @bstansberry @fjuma @jstourac @darranl @wildfly-ci