[WFLY-13625] Security realms should support specifying the charset and encoding for credentials. #13548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wildfly-ci
added
the
deps-ok
bstansberry
added
Feature
SoniaZaldana
force-pushed
the
WFLY-13625
branch
from
5d255f1
to
4d8a881
Compare
SoniaZaldana
force-pushed
the
WFLY-13625
branch
3 times, most recently
from
745e6f5
to
c6ef824
Compare
fjuma
approved these changes
May 27, 2021
|
|
||
| The various password mappers allow loading multiples values from the database to reconstruct the password. | ||
| This information is then used to hash the client provided password to compare against the password reconstructed from the | ||
| database. |
There was a problem hiding this comment.
Maybe this could be reworded to something like:
The various password mappers allow loading multiples values from the database to hash the client provided password in order to compare against the password stored in the database.
fjuma
approved these changes
Jun 1, 2021
Closed
|
@SoniaZaldana as discussed we have run into some failures with the new FilesystemRealmTestCase, we should be ready for you to rebase on master now to reproduce locally. |
…d encoding for credentials.
|
Thanks @darranl, I fixed the test failure and rebased. |
|
Thank you @SoniaZaldana CI was clean. |
darranl
approved these changes
Jun 4, 2021
darranl
removed
core-upgrade-needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.redhat.com/browse/WFLY-13625
Requires: https://issues.redhat.com/browse/WFCORE-5027
WildFly Core PR with tests: wildfly/wildfly-core#4324