[WFLY-14078] Check if the subsystem default security domain was mapped to an Elytron domain before applying for the component. #13718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wildfly-ci
added
the
deps-ok
darranl
force-pushed
the
WFLY-14078
branch
2 times, most recently
from
38888cd
to
73fa21f
Compare
|
I have just replaced the commit for this PR, the prior fix was still applying the Elytron domain too liberally - now the Elytron domain is applied in one of these situations:
|
…d to an Elytron domain before applying for the component.
…ans have legacy security domains defined.
…yment's ClassLoader if at least one EJBComponent will fall back to the subsystem defined default.
|
@chengfang / @tadamski / @fjuma I am hopeful for this CI run, would it be possible to please get some reviews in so we can get on with merging if CI passes. |
fjuma
approved these changes
Nov 19, 2020
chengfang
approved these changes
Nov 19, 2020
|
@darranl This still has the 'hold' label on it; otherwise I'd merge it right now. If you see this when I'm not around don't be shy about just merging it yourself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just submitting the PR now as locally I am running into a number of failures in allTests related to the latest OpenJDK release.
https://issues.redhat.com/browse/WFLY-14078