WFLY-14176 Update Apache commons CLI 1.4 #13794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
wildfly-ci
added
the
deps-ok
|
@darranl I think this is ok. It's used by VaultTool and JDR and seems like it should be fine for both. There's also this in the legacy security subsystem module: I can't see any reason why that is needed. The module doesn't import any classes from it nor does commons-cli provide any Service impls that might be pulled in via ServiceLoader. Looking at the commit that added that line I don't see any reason for its addition either. |
boris-unckel
force-pushed
the
WFLY-14176_update_commons_cli
branch
from
e2c5881
to
b63507f
Compare
|
/retest |
1 similar comment
|
/retest |
|
retest this please |
|
Thanks, @boris-unckel! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes WFLY-14176