Remove servlet and core FP dependencies #13924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
deps-ok
jfdenise
force-pushed
the
separated-fp-build
branch
6 times, most recently
from
51a54bd
to
56496d7
Compare
|
@bstansberry , this PR can be reviewed. |
jfdenise
force-pushed
the
separated-fp-build
branch
2 times, most recently
from
077e1c6
to
683e4f9
Compare
jfdenise
force-pushed
the
separated-fp-build
branch
from
683e4f9
to
8fdcbdf
Compare
|
/retest |
1 similar comment
|
/retest |
jfdenise
force-pushed
the
separated-fp-build
branch
from
8fdcbdf
to
e92992b
Compare
bstansberry
approved these changes
Feb 22, 2021
jfdenise
force-pushed
the
separated-fp-build
branch
from
e92992b
to
a044c04
Compare
…-servlet One aspect of this is moving the input files for license.xml generation from src/license to src/main/resource/license so it can be handled consistently with other resource files. This change was implemented for all feature packs, not just servlet. There was also some cleanup of direct declaration of the org.wildfly.core:wildfly-core-galleon-pack, which is not really on-topic for this JIRA. It was done trying to resolve problems but in the end was probably not relevant to the solution. But it's the right thing to do so I left it.
…pack; just use source from core
jfdenise
force-pushed
the
separated-fp-build
branch
from
a044c04
to
6f6d236
Compare
bstansberry
added
23.x
Critical
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
https://issues.redhat.com/browse/WFLY-14169
https://issues.redhat.com/browse/WFLY-14170
https://issues.redhat.com/browse/WFLY-14362
https://issues.redhat.com/browse/WFLY-14363
@bstansberry , In addition to the automated tests, I have done a diff of the various distributions as well as the provisioned layers (layers tests), and all diffs are expected (related to some html and xml licenses that don't exist anymore).
Component upgrade required to properly handle core-tools:
https://issues.redhat.com/browse/WFLY-14374
diff: wildfly/galleon-plugins@5.0.0.Final...5.1.0.Final
Bootable JAR JDK 8
https://ci.wildfly.org/buildConfiguration/WF_BootableJarLinuxJdk8/239565
Bootable JAR EE9
https://ci.wildfly.org/buildConfiguration/WF_Ee9BootableJarLinuxJdk8/239566
Bootable JAR JDK 11 Windows
https://ci.wildfly.org/buildConfiguration/WF_BootableJarWindowsJdk11/239568