Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace 'Java EE Connector Architecture|JCA' references in java doc w… #14032

Merged
merged 1 commit into from Mar 8, 2021
Merged

Replace 'Java EE Connector Architecture|JCA' references in java doc w… #14032

merged 1 commit into from Mar 8, 2021

Conversation

RanabirChakraborty
Copy link
Contributor

Issue: https://issues.redhat.com/browse/WFLY-14319
(Replace "Java EE Connector Architecture|JCA" references in java doc with corresponding Jakarta EE ones)
Link with: #13808

@RanabirChakraborty
Copy link
Contributor Author

CC: @asoldano @scottmarlow

@github-actions github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label Feb 23, 2021
@asoldano
Copy link
Contributor

@tadamski, can you please review? (/cc @maeste )

RanabirChakraborty
RanabirChakraborty commented Feb 23, 2021
View reviewed changes
Copy link
Contributor Author

@RanabirChakraborty RanabirChakraborty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In MessageEndpointService.java i have changed JCA 1.6 -> Jakarta Connectors
which is not a correct specification name according to https://jakarta.ee/specifications/connectors/
What should I put here?

RanabirChakraborty
RanabirChakraborty commented Feb 23, 2021
View reviewed changes
ejb3/src/main/java/org/jboss/as/ejb3/inflow/MessageEndpointService.java Outdated
@@ -42,7 +42,7 @@
/**
* Returns the classloader that's applicable for the endpoint application.
* This classloader will be used to set the thread context classloader during the beforeDelivery()/afterDelivery()
* callbacks as mandated by the JCA 1.6 spec
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed JCA 1.6 -> Jakarta Connectors
which is not a correct specification name according to https://jakarta.ee/specifications/connectors/
What should I put here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maeste @tadamski ^

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maeste @tadamski ^

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The point is the callbacks is mandatory starting from JCA 1.6. I think we should keep it as "JCA 1.6 and Jakarta Connectors >= 1.7"

maeste
maeste reviewed Mar 2, 2021
View reviewed changes
docs/src/main/asciidoc/_galleon/Galleon_layers.adoc Outdated
@@ -452,7 +452,7 @@ link:#gal.io[io] +
link:#gal.base-server[base-server] +

|[[gal.resource-adapters]]resource-adapters
|Support for deployment of JCA adapters.
|Support for deployment of Jakarta Connectors adapters.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to call it "Jakarta Connectors resource adapters

connector/src/main/java/org/jboss/as/connector/logging/ConnectorLogger.java Outdated
@@ -778,13 +778,13 @@
DeploymentUnitProcessingException invalidConnectionFactory(String cf, String ra, String jndiName);

/**
* Admin object declared for JCA 1.0 archive
* Admin object declared for Jakarta Connectors archive
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure about this change, this is a feature of a specific version of JCA spec, I think we should keep it as is

connector/src/main/java/org/jboss/as/connector/logging/ConnectorLogger.java Outdated
*
* @param ra The resource adapter
* @param jndiName The JNDI name
* @return a {@link DeploymentUnitProcessingException} for the error.
*/
@Message(id = 84, value = "Admin object declared for JCA 1.0 resource adapter '%s' while deploying %s")
@Message(id = 84, value = "Admin object declared for Jakarta Connectors resource adapter '%s' while deploying %s")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure about this change, this is a feature of a specific version of JCA spec, I think we should keep it as is

ejb3/src/main/java/org/jboss/as/ejb3/inflow/MessageEndpointService.java Outdated
@@ -42,7 +42,7 @@
/**
* Returns the classloader that's applicable for the endpoint application.
* This classloader will be used to set the thread context classloader during the beforeDelivery()/afterDelivery()
* callbacks as mandated by the JCA 1.6 spec
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The point is the callbacks is mandatory starting from JCA 1.6. I think we should keep it as "JCA 1.6 and Jakarta Connectors >= 1.7"

connector/src/main/java/org/jboss/as/connector/logging/ConnectorLogger.java Outdated
@@ -778,13 +778,13 @@
DeploymentUnitProcessingException invalidConnectionFactory(String cf, String ra, String jndiName);

/**
* Admin object declared for JCA 1.0 archive
* Admin object declared for Jakarta Connectors archive
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure about this change, this is a feature of a specific version of JCA spec, I think we should keep it as is

connector/src/main/java/org/jboss/as/connector/logging/ConnectorLogger.java Outdated
*
* @param ra The resource adapter
* @param jndiName The JNDI name
* @return a {@link DeploymentUnitProcessingException} for the error.
*/
@Message(id = 84, value = "Admin object declared for JCA 1.0 resource adapter '%s' while deploying %s")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure about this change, this is a feature of a specific version of JCA spec, I think we should keep it as is

connector/src/main/resources/org/jboss/as/connector/subsystems/jca/LocalDescriptions.properties Outdated
jca=The Jakarta EE Connector Architecture (JCA) subsystem providing general configuration for resource adapters
jca.add=Add the JCA subsystem
jca.remove=Remove the JCA subsystem
jca=The Jakarta Connectors Architecture (JCA) subsystem providing general configuration for resource adapters
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is still valid mentioning JCA as short name?

docs/src/main/asciidoc/_galleon/Galleon_layers.adoc Outdated
@@ -452,7 +452,7 @@ link:#gal.io[io] +
link:#gal.base-server[base-server] +

|[[gal.resource-adapters]]resource-adapters
|Support for deployment of JCA adapters.
|Support for deployment of Jakarta Connectors adapters.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was wrong before calling it just "adapters" instead of "resource adapters". I think it's the opportunity to fix it as "Jakarta Connectors resource adapters"

@RanabirChakraborty
Copy link
Contributor Author

@maeste Thanks for the review! did the changes accordingly :)

@asoldano asoldano merged commit e3a92a5 into wildfly:master Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maeste maeste maeste left review comments

@asoldano asoldano asoldano left review comments

@tadamski tadamski tadamski approved these changes

Assignees
No one assigned
Labels
deps-ok Dependencies have been checked, and there are no significant changes
Projects
None yet
Milestone
No milestone
4 participants
@RanabirChakraborty @asoldano @maeste @tadamski