WFLY-14388 resolve expression for transaction-support attribute in r-a subsystem. #14059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
deps-ok
|
Sounds fine so long as we're in agreement re what I say at https://issues.redhat.com/browse/WFLY-14388?focusedCommentId=15896045&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-15896045 |
istraka
suggested changes
Mar 8, 2021
| @@ -321,7 +321,11 @@ private void parseResourceAdapter(final XMLExtendedStreamReader reader, final Li | |||
| } | |||
| String value = rawElementText(reader); | |||
| TRANSACTION_SUPPORT.parseAndSetParameter(value, operation, reader); | |||
| isXa = value != null && TransactionSupportEnum.valueOf(value) == TransactionSupportEnum.XATransaction; | |||
| ModelNode transactionSupport = TRANSACTION_SUPPORT.parse(value, reader); | |||
There was a problem hiding this comment.
SimpleAttributeDefinition#parse is deprecated. Can you use getParser as JavaDoc suggests?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/WFLY-14388 resolve expression for transaction-support attribute in r-a subsystem.
In r-a subsystem
ResourceAdapterSubsystemParserandResourceAdapterParserrely on resolved value oftransaction-support(user specified transaction support level of the resource adapter amongNoTransaction,LocalTransactionandXATransaction) to read/write connection-definition attributes. It's not a perfect approach, but that's the reasontransaction-supportattribute is defined to determine XA.Also I have removed unused
isXainparseTimeOutand unusedresource-adapters-xapool-expression2.xml@tadamski please review. thanks.