[WFLY-14546] Restore naming context #14101
Conversation
github-actions
bot
added
the
deps-ok
|
|
||
| @Override | ||
| public void execute(Runnable command) { | ||
| WeldTaskWrapper task = new WeldTaskWrapper(command, NamespaceContextSelector.getCurrentSelector()); |
There was a problem hiding this comment.
Avoid wrapping if Weld isn't yet started, org.jboss.weld.Container#instance() can be used to check state.
You can see how we do similar check here - https://github.com/wildfly/wildfly/blob/master/weld/subsystem/src/main/java/org/jboss/as/weld/WeldProvider.java#L69-L70
There was a problem hiding this comment.
Thanks @manovotn, I added the check
|
@manovotn can you re-review this please? Should I ask anybody else for the review as well? |
|
I am fine with this. It shouldn't affect bootstrap at least. The only other person you can try to get review from is @mkouba ;-) |
| } | ||
| } | ||
|
|
||
| class WeldTaskWrapper implements Runnable { |
There was a problem hiding this comment.
This class and WeldExecutor do not seem to need to access the enclosing class (WeldExecutorServices) so it might make sense to make it static.
There was a problem hiding this comment.
@spyrkob Can you make this change? Thanks.
There was a problem hiding this comment.
Sorry, I missed that. It's updated now.
|
Looks good. But I would be interested in the numbers as well ;-). |
|
/retest |
Issue: https://issues.redhat.com/browse/WFLY-14546