Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WFLY-14767 Upgrade to Hibernate Search 5.10.11.Final #14281

Merged
merged 4 commits into from May 13, 2021
Merged

WFLY-14767 Upgrade to Hibernate Search 5.10.11.Final #14281

merged 4 commits into from May 13, 2021

Conversation

yrodiere
Copy link
Contributor

@yrodiere yrodiere commented May 6, 2021

https://issues.redhat.com/browse/WFLY-14767

cc @scottmarlow , @gbadner , @wolfc

This pull request is based on #14177: we need the upgrade to Avro 1.10 in order for Hibernate Search 5.10.11 to work correctly. (and vice-versa: we need the upgrade to Hibernate Search 5.10.11 in order to upgrade to Avro 1.10, because Hibernate Search 5.10.10 and below will not work with Avro 1.10).

See the relevant conversation here: #14177 (review)

The full changelog since Hibernate Search 5.10.7.Final is available here. To sum up:

  • Upgrade to Avro 1.10 / Jackson 2
  • Various upgrades to a higher version of ORM 5.3 => no consequences on WildFly
  • Various upgrades to tests dependencies and the build => no consequences on WildFly
  • HSEARCH-3767: Elasticsearch date/time bridges throw NPE on projections => not relevant to WildFly, as we don't package the Elasticsearch integration as a module
  • HSEARCH-3801: Hibernate Search blocks loading => not relevant to WildFly, as we don't package this artifact as a module

@github-actions github-actions bot added the deps-changed Dependencies have been checked, and there are changes highlighted in a comment label May 6, 2021
@github-actions
Copy link

github-actions bot commented May 6, 2021

Dependency Tree Analyzer Output:

Removed Dependencies:

  • org.codehaus.jackson:jackson-core-asl:jar:1.9.13.redhat-00007:compile
  • org.codehaus.jackson:jackson-jaxrs:jar:1.9.13.redhat-00007:compile
  • org.codehaus.jackson:jackson-mapper-asl:jar:1.9.13.redhat-00007:compile
  • org.codehaus.jackson:jackson-xc:jar:1.9.13.redhat-00007:compile
  • org.jboss.resteasy:resteasy-jackson-provider:jar:3.15.1.Final:compile

CC @wildfly/prod

Copy link
Contributor

@scottmarlow scottmarlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on the Hibernate Search update part of this pull request via 280ad00

@bstansberry
Copy link
Contributor

@ronsigal Any concerns? See #14177 for the main discussion; this PR just adds a necessary 4th commit but one that is unrelated to JAXRS.

@jamezp
Copy link
Member

jamezp commented May 11, 2021

What is the reason for the removal of Jackson and the RESTEasy modules? While I don't fully disagree with removing them, as we might be doing that soon anyway, I don't see a reason for it in this PR.

@bstansberry
Copy link
Contributor

@jamezp This PR is really just a continuation of #14177; see the discussion there. The overall purpose of the work is to remove the unmaintained except by EAP SET codehaus jackson which long ago was superceded by FasterXML Jackson. The Hibernate Search upgrade was just the last piece in the puzzle.

Copy link
Member

@jamezp jamezp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies for not reading the comments on the other PR. I'm completely okay with this. The one remaining question I'd have is should we add some documentation about this or maybe add require a release note for WildFly 24 indicating it's been removed.

@bstansberry
Copy link
Contributor

@jamezp I filed https://issues.redhat.com/browse/WFLY-14786 to capture suggestions like your previous comment. Thanks!

@bstansberry
Copy link
Contributor

/retest

@bstansberry bstansberry merged commit 07f0a70 into wildfly:master May 13, 2021
@bstansberry
Copy link
Contributor

Thanks @yrodiere @wolfc !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps-changed Dependencies have been checked, and there are changes highlighted in a comment
Projects
None yet
5 participants