New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WFLY-14767 Upgrade to Hibernate Search 5.10.11.Final #14281
Conversation
Dependency Tree Analyzer Output: Removed Dependencies:
CC @wildfly/prod |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving based on the Hibernate Search update part of this pull request via 280ad00
What is the reason for the removal of Jackson and the RESTEasy modules? While I don't fully disagree with removing them, as we might be doing that soon anyway, I don't see a reason for it in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My apologies for not reading the comments on the other PR. I'm completely okay with this. The one remaining question I'd have is should we add some documentation about this or maybe add require a release note for WildFly 24 indicating it's been removed.
@jamezp I filed https://issues.redhat.com/browse/WFLY-14786 to capture suggestions like your previous comment. Thanks! |
/retest |
https://issues.redhat.com/browse/WFLY-14767
cc @scottmarlow , @gbadner , @wolfc
This pull request is based on #14177: we need the upgrade to Avro 1.10 in order for Hibernate Search 5.10.11 to work correctly. (and vice-versa: we need the upgrade to Hibernate Search 5.10.11 in order to upgrade to Avro 1.10, because Hibernate Search 5.10.10 and below will not work with Avro 1.10).
See the relevant conversation here: #14177 (review)
The full changelog since Hibernate Search 5.10.7.Final is available here. To sum up: