Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFLY-14815] Fix ForwardedHandlerTestCase to comply with UNDERTOW-1837 #14319

Merged
merged 2 commits into from Jun 4, 2021

Conversation

fl4via
Copy link
Contributor

@fl4via fl4via commented May 26, 2021

Jira: https://issues.redhat.com/browse/WFLY-14815

This is the second part of the fix required to make ForwardedHandlerTestCase compliant with UNDERTOW-1837.
The first part is #14314
Requires upgrade of WildFly Core with Undertow upgrade: wildfly/wildfly-core#4604

@bstansberry
Copy link
Contributor

I'm going to kill the CI jobs on this as we know the tests won't pass yet.

@github-actions github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label May 26, 2021
@bstansberry
Copy link
Contributor

/retest

@spyrkob
Copy link
Contributor

spyrkob commented May 27, 2021

@fl4via should the expected values be set to something like

final InetAddress address = InetAddress.getByName(url.getHost());
final String localAddrName = address.getHostName();
final String localAddr = address.getHostAddress() + ":" + url.getPort();

to get the values of address server is bound to?

@fl4via
Copy link
Contributor Author

fl4via commented May 27, 2021

@spyrkob possibly, I'm going to give it a try.

@spyrkob
Copy link
Contributor

spyrkob commented Jun 1, 2021

The SM testsuite fails because resolving hostname requires SocketPermission(host, "resolve")). Since that's expected behaviour is it OK to just add the permission to the test deployment?

@bstansberry
Copy link
Contributor

@spyrkob @fl4via Yes, adding the permission to the deployment is the correct thing to do.

@fl4via
Copy link
Contributor Author

fl4via commented Jun 3, 2021

@spyrkob thanks for your commit! @bstansberry I hope the tests will pass now :-)

@bstansberry bstansberry merged commit c178b2d into wildfly:master Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps-ok Dependencies have been checked, and there are no significant changes
Projects
None yet
3 participants