[WFLY-13793]: Allow remote jms queue/topic not to use legacy amq1 prefix. #14412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
deps-ok
ehsavoie
force-pushed
the
WFLY-13793
branch
2 times, most recently
from
3980265
to
31eb8ea
Compare
soul2zimate
approved these changes
Jul 5, 2021
There was a problem hiding this comment.
@ehsavoie Thank you for the detailed tests. Overall this LGTM, except a few minor comments.
...system/src/main/java/org/wildfly/extension/messaging/activemq/QueueReadAttributeHandler.java
Outdated
Show resolved
Hide resolved
...wildfly/extension/messaging/activemq/deployment/JMSDestinationDefinitionInjectionSource.java
Outdated
Show resolved
Hide resolved
...ssaging/jms/external/prefix/ExternalJMSDestinationDefinitionMessagingDeploymentTestCase.java
Show resolved
Hide resolved
ehsavoie
force-pushed
the
WFLY-13793
branch
4 times, most recently
from
fdfe65b
to
5fefce3
Compare
soul2zimate
reviewed
Aug 25, 2021
...m/src/main/java/org/wildfly/extension/messaging/activemq/jms/ExternalJMSQueueDefinition.java
Show resolved
Hide resolved
ehsavoie
force-pushed
the
WFLY-13793
branch
2 times, most recently
from
9f92a3e
to
e8dc521
Compare
…fix. * Adding new mode attribute for external destinations. * Adding new supported property for @JMSDestination * Adding tests * Adding docs for disabling the use of legacy amq1 prefix for queue or topic defined in the model or using annotations. Jira: https://issues.redhat.com/browse/WFLY-13793
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.redhat.com/browse/WFLY-13793