[WFLY-15452] - allow specifying AJP_ALLOWED_REQUEST_ATTRIBUTES_PATTERN #14789

baranowb · 2021-10-13T06:45:20Z

Issue: https://issues.redhat.com/browse/WFLY-15452

More information about the wildfly-bot[bot]

kabir

@baranowb I think you need a transformers tests (apologies if there is one and I missed it).

Also, you need to bump UndertowExtension.CURRENT_MODEL_VERSION, since 11.0.0 has already been in a release and you're changing the model

baranowb · 2021-10-26T07:32:50Z

@kabir Thought bump to 12.1 should be enough with just addition of attribute? There is test for model version( subsystem).
ATM Im waiting for @fl4via to clarify some transformer versions vs tests definition, as they seem to be misaligned.

kabir · 2021-10-26T10:22:24Z

@baranowb Yes, bumping the xml was good - you also need to bump the management model version.

baranowb · 2021-10-27T07:51:45Z

@kabir Uh, missed that, but it seems to be a fallout from previous bump, as current was 12, not 11.
I wonder why it did not fail.

fl4via

Have you checked if there is need to update the community documentation in WF as well (in docs dir)?

fl4via · 2021-11-01T07:30:51Z

undertow/src/main/java/org/wildfly/extension/undertow/UndertowExtension.java

@@ -79,7 +79,7 @@
    static final AccessConstraintDefinition LISTENER_CONSTRAINT = new SensitiveTargetAccessConstraintDefinition(
                    new SensitivityClassification(SUBSYSTEM_NAME, "web-connector", false, false, false));

-    private static final ModelVersion CURRENT_MODEL_VERSION = ModelVersion.create(11, 0, 0);
+    private static final ModelVersion CURRENT_MODEL_VERSION = ModelVersion.create(12, 1, 0);


good catch, indeed, I missed that in the previous commit!

fl4via · 2021-11-01T07:32:11Z

undertow/src/main/java/org/wildfly/extension/undertow/UndertowSubsystemParser_12_1.java

+/**
+ * @author <a href="mailto:tomaz.cerar@redhat.com">Tomaz Cerar</a> (c) 2012 Red Hat Inc.
+ * @author Radoslav Husar
+ * @author Flavia Rainone


You can add your name here, Bartosz, so people can easily see that you created this one

fl4via · 2021-11-01T07:37:02Z

undertow/src/main/java/org/wildfly/extension/undertow/UndertowTransformers.java

@@ -125,13 +126,23 @@ private static void registerTransformersWildFly18(ResourceTransformationDescript
                .getAttributeBuilder()
                    .setValueConverter(AttributeConverter.DEFAULT_VALUE, CONNECTION_IDLE_TIMEOUT)
                .end();
+        subsystemBuilder.addChildResource(UndertowExtension.SERVER_PATH)


I could be wrong, but I think transformation is applied in a chain when comparing to an old version, and if that's the case it is enough to add a discard to registerTransformersWildFly25, a new method, in the same way I did for OBFUSCATE_SESSION_ROUTE, have you checked it the tests pass that way?
In other words, registerTransformersWildFly25 would be applied to WF25 and all previous versions

fl4via · 2021-11-01T07:37:29Z

undertow/src/main/java/org/wildfly/extension/undertow/UndertowTransformers.java

                .rejectChildResource(ConsoleAccessLogDefinition.INSTANCE.getPathElement());
+


The same applies here to registerTranformersWildFly16, these changes might not be needed

fl4via · 2021-11-01T07:46:50Z

undertow/src/main/java/org/wildfly/extension/undertow/UndertowTransformers.java

@@ -155,6 +166,12 @@ private static void registerTransformers_EAP_7_2_0(ResourceTransformationDescrip
                    .setDiscard(DiscardAttributeChecker.DEFAULT_VALUE, PRESERVE_PATH_ON_FORWARD)
                    .addRejectCheck(RejectAttributeChecker.DEFINED, PRESERVE_PATH_ON_FORWARD)
                .end();
+        final ResourceTransformationDescriptionBuilder serverBuilder = subsystemBuilder.addChildResource(UndertowExtension.SERVER_PATH);
+
+        final AttributeTransformationDescriptionBuilder ajp = serverBuilder.addChildResource(UndertowExtension.AJP_LISTENER_PATH).getAttributeBuilder()


The same goes for the EAP. I think we need to add a registerTransformers_EAP_7_4_0 and discard it. I'm not sure the reject has any effect, after discarding it?

Im almost sure it had to be done, buy it might have been due to wrong current model. I will double check.

fl4via · 2021-11-01T07:59:12Z

undertow/src/test/java/org/wildfly/extension/undertow/UndertowSubsystem121TestCase.java

+/**
+ * Test for UndertowSubsystem with subsystem schema version 12.0.
+ *
+ * @author Flavia Rainone


Add your name to the author list

fl4via · 2021-11-01T08:01:16Z

undertow/src/main/resources/schema/wildfly-undertow_12_1.xsd

+                    </xs:annotation>
+                </xs:attribute>
+                <xs:attribute name="max-ajp-packet-size" type="xs:int"/>
+                <xs:attribute name="allowed-request-attributes-pattern" use="optional" type="xs:string"/>


please, add a CDATA documenting it here as well

fl4via · 2021-11-01T08:07:37Z

undertow/src/main/java/org/wildfly/extension/undertow/Namespace.java

    ;

    /**
     * The current namespace version.
     */
-    public static final Namespace CURRENT = UNDERTOW_12_0;
+    public static final Namespace CURRENT = UNDERTOW_12_1;


Historically we have been incrementing only the major version number for quite a while. It is intersting that you brought up this, though, because I see that Undertow has 1.1, 1.2 and 3.1. @bstansberry do we have any policies in WF as to when should we upgrade the major model version versus the minor one?

@fl4via @baranowb We should always do a major bump in WildFly main / WildFly Core main. That eliminates varying interpretations of what's 'minor' and leaves minor versions available for use in other streams if necessary.

I've never gotten a sense that people are trying to get semantic meaning from our API/schema versions so there's not much downside to just doing majors.

@bstansberry roger.

darranl

For changes like this it is clearer both now and in the future to separate the version bump into it's own separate commit, when the two are combined like this it is not possible to use the GitHub UI or git diff tools later to identify the changes made to the schema.

darranl · 2021-11-01T09:54:55Z

Added "missing_reqs" as the requirements for a feature request have not been met.

Also related to my comment about the schema version etc.. I see you have a second PR also duplicating the changes - this is another reason to use a separate commit for the bump - both RFEs can then continue from the same commit reducing the scope for conflict.

baranowb · 2021-11-02T08:59:13Z

Have you checked if there is need to update the community documentation in WF as well (in docs dir)?

Yes. AFAIR there is no documentation that covers atttribs now, its all generated from model and descriptor files as "model reference.

fl4via · 2022-03-04T04:52:52Z

Have you checked if there is need to update the community documentation in WF as well (in docs dir)?

Yes. AFAIR there is no documentation that covers atttribs now, its all generated from model and descriptor files as "model reference.

In fact, you're right.

wildfly-ci · 2022-12-15T22:25:26Z

Hello, baranowb. I'm waiting for one of the admins to verify this patch with /ok-to-test in a comment.

baranowb · 2023-11-09T13:01:39Z

Removed label after rebase.

Added by mistake

github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label Oct 13, 2021

kabir previously requested changes Oct 25, 2021

View reviewed changes

fl4via suggested changes Nov 1, 2021

View reviewed changes

darranl reviewed Nov 1, 2021

View reviewed changes

darranl added the missing-reqs Features missing one or more of the pre-merge requirements label Nov 1, 2021

baranowb force-pushed the WFLY-15452 branch 2 times, most recently from 44571b8 to f1c5113 Compare November 2, 2021 10:25

bstansberry added the Feature PR provides a new feature label Nov 5, 2021

baranowb force-pushed the WFLY-15452 branch 2 times, most recently from fb63e03 to 68f05b7 Compare November 17, 2021 10:49

darranl added the rebase-this PR has a merge conflict. label Jan 31, 2022

baranowb force-pushed the WFLY-15452 branch from 68f05b7 to 9d83615 Compare February 9, 2022 10:01

baranowb force-pushed the WFLY-15452 branch from 9d83615 to 6fd15be Compare November 9, 2023 13:00

wildfly-bot bot requested a review from fl4via November 9, 2023 13:00

baranowb removed the rebase-this PR has a merge conflict. label Nov 9, 2023

baranowb requested a review from kabir November 9, 2023 13:06

kabir removed their request for review November 9, 2023 13:20

fl4via approved these changes May 3, 2024

View reviewed changes

baranowb force-pushed the WFLY-15452 branch from 6fd15be to 494992e Compare May 13, 2024 09:03

wildfly-bot bot requested a review from fl4via May 13, 2024 09:03

[WFLY-15452] - allow specifying AJP_ALLOWED_REQUEST_ATTRIBUTES_PATTERN

e6c6167

[WFLY-15452] bump undertow version

31b82fe

baranowb force-pushed the WFLY-15452 branch from 494992e to 31b82fe Compare May 20, 2024 08:02

[WFLY-15452] Switch to Stability.PREVIEW level

7dc1ab9

baranowb force-pushed the WFLY-15452 branch from 7f1d25b to 7dc1ab9 Compare May 20, 2024 09:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WFLY-15452] - allow specifying AJP_ALLOWED_REQUEST_ATTRIBUTES_PATTERN #14789

[WFLY-15452] - allow specifying AJP_ALLOWED_REQUEST_ATTRIBUTES_PATTERN #14789

baranowb commented Oct 13, 2021 •

edited by wildfly-bot bot

kabir left a comment

baranowb commented Oct 26, 2021

kabir commented Oct 26, 2021

baranowb commented Oct 27, 2021 •

edited

fl4via left a comment

fl4via Nov 1, 2021

fl4via Nov 1, 2021

fl4via Nov 1, 2021

fl4via Nov 1, 2021

fl4via Nov 1, 2021

baranowb Nov 2, 2021

fl4via Nov 1, 2021

fl4via Nov 1, 2021

fl4via Nov 1, 2021

bstansberry Nov 5, 2021

baranowb Nov 15, 2021

darranl left a comment

darranl commented Nov 1, 2021

baranowb commented Nov 2, 2021

fl4via commented Mar 4, 2022

wildfly-ci commented Dec 15, 2022

baranowb commented Nov 9, 2023

		.rejectChildResource(ConsoleAccessLogDefinition.INSTANCE.getPathElement());

[WFLY-15452] - allow specifying AJP_ALLOWED_REQUEST_ATTRIBUTES_PATTERN #14789

Are you sure you want to change the base?

[WFLY-15452] - allow specifying AJP_ALLOWED_REQUEST_ATTRIBUTES_PATTERN #14789

Conversation

baranowb commented Oct 13, 2021 • edited by wildfly-bot bot

kabir left a comment

Choose a reason for hiding this comment

baranowb commented Oct 26, 2021

kabir commented Oct 26, 2021

baranowb commented Oct 27, 2021 • edited

fl4via left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

darranl left a comment

Choose a reason for hiding this comment

darranl commented Nov 1, 2021

baranowb commented Nov 2, 2021

fl4via commented Mar 4, 2022

wildfly-ci commented Dec 15, 2022

baranowb commented Nov 9, 2023

baranowb commented Oct 13, 2021 •

edited by wildfly-bot bot

baranowb commented Oct 27, 2021 •

edited