[WFLY-15503] Remove duplicate if/else block (weld) #14799
Conversation
github-actions
bot
added
the
deps-ok
| if (PrivateSubDeploymentMarker.isPrivate(deploymentUnit) | ||
| // if any deployments have a beans.xml we need to load portable extensions | ||
| // even if this one does not. | ||
| && !WeldDeploymentMarker.isPartOfWeldDeployment(deploymentUnit)) { |
There was a problem hiding this comment.
This logical statement is not functionally equivalent to the previous one. With previous logic, a deploymentUnit with PrivateSubDeploymentMarker.isPrivate(deploymentUnit) == false could still be excluded from processing if the second condition was met. However, in your PR, it would be processed.
If you want to collapse this if statement, then it would have to look like this:
if (!WeldDeploymentMarker.isPartOfWeldDeployment(deploymentUnit)) {
return;
}
(plus keeping the comment)
There was a problem hiding this comment.
@manovotn thanks for your review. Yes, sure, I should have seen that. Fix is ongoing...
boris-unckel
force-pushed
the
WFLY-15503_remove_dup_ifelse_weld
branch
from
cde97ae
to
3657460
Compare
|
@boris-unckel CI is failing because of checkstyle violation. Otherwise, I am fine with this PR. |
boris-unckel
force-pushed
the
WFLY-15503_remove_dup_ifelse_weld
branch
from
3657460
to
fad6bba
Compare
|
@manovotn extremely embarrassing. Fixed. |
Not at all, happens all the time :-) |
Fixes https://issues.redhat.com/browse/WFLY-15503