Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFLY-15732] / [WFLY-15356] Remove use of security-plugins from Undertow subsystem. #14936

Merged
merged 3 commits into from Jan 16, 2022

Conversation

darranl
Copy link
Contributor

@darranl darranl commented Nov 23, 2021

@darranl
Copy link
Contributor Author

darranl commented Nov 23, 2021

Hello @fl4via could you please review this one, hopefully helps with less code to transform in the Undertow subsystem as well as this removes some Jakarta API implementations.

@pferraro Could you please take a look at the clustering code I have deleted and let me know if I gone far enough / too far?

There will be some further clean up later when it comes to making application security domain resources optional, but for now I just want to eliminate the final pieces of code still calling the legacy APIs and report an error if they are called.

@github-actions github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label Nov 23, 2021
@darranl darranl added the EE9 label Nov 24, 2021
Copy link
Contributor

@ropalka ropalka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is about code removal I was able to review this PR.

Copy link
Contributor

@pferraro pferraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the intention to deprecate the resource defined by HostSingleSignOnDefinition?
This resource is still functional, and this PR only seems to remove clustered behavior (the local implementation is still intact).

public class UndertowSecuritySerializationContextInitializer extends AbstractSerializationContextInitializer {

public UndertowSecuritySerializationContextInitializer() {
super("io.undertow.security.api.proto");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file clustering/web/undertow/src/main/resources/io.undertow.security.api.proto should also be removed.

* {@link SessionManagementProviderFactory} for Undertow using either the {@link DistributableSSOManagementProvider} for the given host, the default provider, or a legacy provider.
* @author Paul Ferraro
*/
@MetaInfServices(HostSingleSignOnManagementProvider.class)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the distributed HostSingleSignOnManagementProvider was removed (by deleting this class and its supporting classes), the org.wildfly.extension.undertow.HostSingleSignOnServiceHandler class will still configure an in-memory single sign-on provider.
Should this not also be removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps-ok Dependencies have been checked, and there are no significant changes
Projects
None yet
3 participants